Bugzilla – Attachment 15267 Details for
Bug 9583
OPAC cart button display problem in Chromium
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9583 - OPAC cart button display problem in Chromium
Bug-9583---OPAC-cart-button-display-problem-in-Chr.patch (text/plain), 2.40 KB, created by
Katrin Fischer
on 2013-02-12 07:32:41 UTC
(
hide
)
Description:
Bug 9583 - OPAC cart button display problem in Chromium
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-02-12 07:32:41 UTC
Size:
2.40 KB
patch
obsolete
>From a0a043b48ac1e816d5ae538f9975dc1984241f3f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 11 Feb 2013 08:19:43 -0500 >Subject: [PATCH] Bug 9583 - OPAC cart button display problem in Chromium > >Legacy markup in the script which generates the OPAC's Cart button >causes display problems in Chrome under the new HTML5 doctype. > >This patch removes the extra markup, which has been unnecessary since >we changed the way the Cart and Lists buttons are displayed in Bug >7584. > >To test, view the OPAC in several browsers, including a Chromium-based >browser (Specifically Chromium-based. It is not a WebKit-related bug). >The Cart button should display correctly with and without items in the >cart. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Comment: Works great, back to normal. >Tested in windows (chrome, firefox, opera) and linux (chrome, chromium) > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Tested with Chromium and Firefox in Ubuntu. No regression found and >display is correct now. >--- > .../opac-tmpl/prog/en/includes/doc-head-close.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc b/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc >index 35884af..8c5ff1f 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc >@@ -66,7 +66,7 @@ > var MSG_ITEM_IN_CART = _("In your cart"); > var MSG_IN_YOUR_CART = _("Items in your cart: "); > var MSG_ITEM_NOT_IN_CART = _("Add to your cart"); >- $("#cartDetails").ready(function(){ $("#cmspan").html("<a href=\"#\" id=\"cartmenulink\" class=\"\"><i><\/i><span><i><\/i><span><\/span><span id=\"carticon\"></span> "+_("Cart")+"<span id=\"basketcount\"><\/span><\/span><\/a>"); }); [% ELSE %][% IF ( virtualshelves ) %] >+ $("#cartDetails").ready(function(){ $("#cmspan").html("<a href=\"#\" id=\"cartmenulink\"><span id=\"carticon\"></span> "+_("Cart")+"<span id=\"basketcount\"><\/span><\/a>"); }); [% ELSE %][% IF ( virtualshelves ) %] > var MSG_NO_RECORD_SELECTED = _("No item was selected");[% END %][% END %] > [% IF ( opacuserlogin ) %][% IF ( TagsEnabled ) %]var MSG_TAGS_DISABLED = _("Sorry, tags are not enabled on this system."); > var MSG_TAG_ALL_BAD = _("Error! Your tag was entirely markup code. It was NOT added. Please try again with plain text."); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9583
:
15211
|
15235
|
15249
| 15267