Bugzilla – Attachment 152741 Details for
Bug 34130
ILL requests table won't load if request_placed date is null
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34130: Make requested_date nullable in api definition
Bug-34130-Make-requesteddate-nullable-in-api-defin.patch (text/plain), 1.46 KB, created by
Nick Clemens (kidclamp)
on 2023-06-27 13:40:10 UTC
(
hide
)
Description:
Bug 34130: Make requested_date nullable in api definition
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-06-27 13:40:10 UTC
Size:
1.46 KB
patch
obsolete
>From d1f7b2b44ffd2473a119b6b962a67b56bb5bf446 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 27 Jun 2023 13:23:08 +0000 >Subject: [PATCH] Bug 34130: Make requested_date nullable in api definition > >This patch allows the requested_date for an ILL request to be NULL to accomodate >older data > >To test: >1 - Install the Koha 2 Koha ILL plugin: > https://gitlab.com/koha-community/plugins/koha-plugin-ill-koha >2 - Enable the ILL system preference >3 - Force an ILL request with minimal data from backend: > INSERT INTO illrequests (borrowernumber,biblio_id,branchcode,backend,status) VALUES (5,3,'CPL','Koha','placed'); >4 - View the ILL table >5 - Error: > {"message":"Expected string - got null.","path":"\/body\/0\/requested_date"} >6 - Apply patch >7 - Table loads successfully > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > api/v1/swagger/definitions/ill_request.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/api/v1/swagger/definitions/ill_request.yaml b/api/v1/swagger/definitions/ill_request.yaml >index 7c668bdfb5..2c585d0be5 100644 >--- a/api/v1/swagger/definitions/ill_request.yaml >+++ b/api/v1/swagger/definitions/ill_request.yaml >@@ -24,7 +24,9 @@ properties: > type: string > description: Internal library identifier > requested_date: >- type: string >+ type: >+ - string >+ - "null" > format: date > description: Date the request was placed by the patron > replied_date: >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34130
:
152737
| 152741