Bugzilla – Attachment 153020 Details for
Bug 34107
Sorting agreements by Name actually sorts by ID
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34107: Switch order for id and name feeding the first column in datatables
Bug-34107-Switch-order-for-id-and-name-feeding-the.patch (text/plain), 3.94 KB, created by
Pedro Amorim
on 2023-07-04 15:27:06 UTC
(
hide
)
Description:
Bug 34107: Switch order for id and name feeding the first column in datatables
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-07-04 15:27:06 UTC
Size:
3.94 KB
patch
obsolete
>From 50be7483634bd6364dc4f5081bc86ad7fabdf3dc Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 4 Jul 2023 15:26:27 +0000 >Subject: [PATCH] Bug 34107: Switch order for id and name feeding the first > column in datatables > >Test plan: >* Create 3 agreements, agreement #1 named 'a', agreement #2 named 'c' and agreement #3 named 'b'. >* Go to agreements list, click the Name column header, notice how the agreements get sorted by id #, not by first char in name. Expected order would be abc or cba, but it's acb or bca. >* Apply patch, on k-t-d, run the following if you're not using 'yarn js:watch': > yarn js:build >* Sort the list again on the 'name' column, notice how it now sorts alphabetically as expected, either abc or cba. >--- > .../intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue | 2 +- > .../prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue | 2 +- > .../prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue | 2 +- > .../intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >index 7b523be0fe..4c0ef541a8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >@@ -251,7 +251,7 @@ export default { > return [ > { > title: __("Name"), >- data: "me.agreement_id:me.name", >+ data: "me.name:me.agreement_id", > searchable: true, > orderable: true, > render: function (data, type, row, meta) { >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >index 1999556b0b..b45f3a64ee 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >@@ -167,7 +167,7 @@ export default { > return [ > { > title: __("Name"), >- data: "me.package_id:me.name", >+ data: "me.name:me.package_id", > searchable: true, > orderable: true, > render: function (data, type, row, meta) { >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue >index 026ea0434e..ffb724746f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue >@@ -164,7 +164,7 @@ export default { > return [ > { > title: __("Title"), >- data: "me.publication_title", >+ data: "me.publication_title:me.title_id", > searchable: true, > orderable: true, > render: function (data, type, row, meta) { >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >index dfdb767612..cad4be984e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >@@ -137,7 +137,7 @@ export default { > return [ > { > title: __("Name"), >- data: "me.license_id:me.name", >+ data: "me.name:me.license_id", > searchable: true, > orderable: true, > render: function (data, type, row, meta) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34107
:
152622
|
153008
|
153019
|
153020
|
153052