Bugzilla – Attachment 153096 Details for
Bug 23336
Add an API endpoint for checking an item out to a patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23336: Fix tests
Bug-23336-Fix-tests.patch (text/plain), 1.73 KB, created by
Jonathan Druart
on 2023-07-06 13:42:41 UTC
(
hide
)
Description:
Bug 23336: Fix tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-07-06 13:42:41 UTC
Size:
1.73 KB
patch
obsolete
>From 8424400fe51baec9a08f7280e16bebc26879f833 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 6 Jul 2023 15:41:40 +0200 >Subject: [PATCH] Bug 23336: Fix tests > >Not sure what we were trying to do, but apparently we only use the keys >to generate the id string. How did "please" end up here? >--- > t/db_dependent/api/v1/checkouts.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/api/v1/checkouts.t b/t/db_dependent/api/v1/checkouts.t >index 2e749aa8741..1522e6b0ff8 100755 >--- a/t/db_dependent/api/v1/checkouts.t >+++ b/t/db_dependent/api/v1/checkouts.t >@@ -321,7 +321,7 @@ subtest 'get_availability' => sub { > > # Needs confirm > %needsconfirmation = ( confirm1 => 1, confirm2 => 'please' ); >- my $token = Koha::Token->new->generate_jwt( { id => $librarian->id . ":" . $item1_id . ":confirm1:confirm2:please" }); >+ my $token = Koha::Token->new->generate_jwt( { id => $librarian->id . ":" . $item1_id . ":confirm1:confirm2" }); > $t->get_ok( > "//$userid:$password@/api/v1/checkouts/availability?item_id=$item1_id&patron_id=$patron_id" > )->status_is(200)->json_is( '/blockers' => {} ) >@@ -334,7 +334,7 @@ subtest 'get_availability' => sub { > { > id => $librarian->id . ":" > . $item1_id >- . ":confirm1:confirm2:please", >+ . ":confirm1:confirm2", > token => $confirmation_token > } > ), >@@ -415,7 +415,7 @@ subtest 'add checkout' => sub { > { > id => $librarian->id . ":" > . $item1_id >- . ":confirm1:confirm2:please" >+ . ":confirm1:confirm2" > } > ); > $t->post_ok( >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23336
:
91632
|
91633
|
91634
|
150947
|
150948
|
150949
|
150954
|
150955
|
150956
|
150960
|
150961
|
150962
|
151253
|
151318
|
151319
|
151320
|
151321
|
151322
|
151353
|
151354
|
151355
|
151356
|
151357
|
152712
|
152713
|
152714
|
152715
|
152716
|
152938
|
152999
|
153000
|
153095
|
153096