Bugzilla – Attachment 153293 Details for
Bug 33817
Composition of an item bundle can be changed if checked out
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33817: (QA follow-up) Fix tidyness
Bug-33817-QA-follow-up-Fix-tidyness.patch (text/plain), 1.81 KB, created by
Tomás Cohen Arazi (tcohen)
on 2023-07-10 17:40:34 UTC
(
hide
)
Description:
Bug 33817: (QA follow-up) Fix tidyness
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2023-07-10 17:40:34 UTC
Size:
1.81 KB
patch
obsolete
>From b36b445b12c3a44652f873f84855810bc82ec958 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 10 Jul 2023 14:31:40 -0300 >Subject: [PATCH] Bug 33817: (QA follow-up) Fix tidyness > >This patch fixes some reported tidyness issues with the patches. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Item.pm | 2 +- > Koha/REST/V1/Items.pm | 7 ++----- > 2 files changed, 3 insertions(+), 6 deletions(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index 8d07512b4c6..17791f2994e 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -1790,7 +1790,7 @@ sub remove_from_bundle { > > my $bundle_host = $self->bundle_host; > >- return 0 unless $bundle_host; # Should not we raise an exception here? >+ return 0 unless $bundle_host; # Should not we raise an exception here? > > Koha::Exceptions::Item::Bundle::BundleIsCheckedOut->throw if $bundle_host->checkout; > >diff --git a/Koha/REST/V1/Items.pm b/Koha/REST/V1/Items.pm >index 0a64e26f89b..52c95f59f59 100644 >--- a/Koha/REST/V1/Items.pm >+++ b/Koha/REST/V1/Items.pm >@@ -327,8 +327,7 @@ sub add_to_bundle { > } > ); > } >- elsif ( ref($_) eq 'Koha::Exceptions::Item::Bundle::BundleIsCheckedOut' ) >- { >+ elsif ( ref($_) eq 'Koha::Exceptions::Item::Bundle::BundleIsCheckedOut' ) { > return $c->render( > status => 409, > openapi => { >@@ -336,9 +335,7 @@ sub add_to_bundle { > error_code => 'bundle_checked_out' > } > ); >- } >- elsif ( ref($_) eq 'Koha::Exceptions::Item::Bundle::ItemIsCheckedOut' ) >- { >+ } elsif ( ref($_) eq 'Koha::Exceptions::Item::Bundle::ItemIsCheckedOut' ) { > return $c->render( > status => 409, > openapi => { >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33817
:
151623
|
151660
|
151662
|
151663
|
152723
|
152724
|
152725
|
153228
|
153229
|
153230
| 153293