Bugzilla – Attachment 153402 Details for
Bug 33863
On receive "change currency" is always checked
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33863: (bug 25655 follow-up) Check "Change currency" only if checked before
Bug-33863-bug-25655-follow-up-Check-Change-currenc.patch (text/plain), 1.68 KB, created by
Nick Clemens (kidclamp)
on 2023-07-13 15:37:55 UTC
(
hide
)
Description:
Bug 33863: (bug 25655 follow-up) Check "Change currency" only if checked before
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-07-13 15:37:55 UTC
Size:
1.68 KB
patch
obsolete
>From 5c468eadd5413378269765ba8b728716bd0bb160 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 30 May 2023 14:37:33 +0200 >Subject: [PATCH] Bug 33863: (bug 25655 follow-up) Check "Change currency" only > if checked before > >We should not check "Change currency" if it has not modified in the >original order. > >Test plan: >Create an order with 3+ items >Receive 1 item, don't check "change currency" >Receive an other item >=> "Change currency" is not checked >Check "Change currency", modify the currency and the price >Receive a third item >=> Change currency is checked, invoice currency and price are set >correctly to the previous values > >Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >index 6a0091244e..40fb1ba879 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >@@ -1242,7 +1242,7 @@ > $('#modal-order-main #items-panel').removeClass('show').addClass('hide'); > } > } >- if(row.invoice_unit_price) { >+ if(row.invoice_currency && row.invoice_currency != active_currency) { > $("#select_currency").show(); > $("#unitprice").prop("readonly", true); > $("input[name='change_currency']").prop('checked', true); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33863
:
151796
|
153043
|
153306
|
153341
|
153342
|
153343
| 153402 |
153403
|
153404