Bugzilla – Attachment 153481 Details for
Bug 32986
Add ability to generate custom slips for patrons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32986: (follow-up) Tidy conditional in letter.pl
Bug-32986-follow-up-Tidy-conditional-in-letterpl.patch (text/plain), 3.69 KB, created by
Nick Clemens
on 2023-07-14 12:56:06 UTC
(
hide
)
Description:
Bug 32986: (follow-up) Tidy conditional in letter.pl
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2023-07-14 12:56:06 UTC
Size:
3.69 KB
patch
obsolete
>From bf4503b9cfa005c2147a30dab9f2792957fdd51b Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 14 Jul 2023 12:47:29 +0000 >Subject: [PATCH] Bug 32986: (follow-up) Tidy conditional in letter.pl > >--- > tools/letter.pl | 48 +++++++++++++++++++++--------------------------- > 1 file changed, 21 insertions(+), 27 deletions(-) > >diff --git a/tools/letter.pl b/tools/letter.pl >index 4214d8e2cc..0e3ece1363 100755 >--- a/tools/letter.pl >+++ b/tools/letter.pl >@@ -240,35 +240,29 @@ sub add_form { > > my $field_selection; > push @{$field_selection}, add_fields('branches'); >- if ($module eq 'reserves') { >- push @{$field_selection}, add_fields('borrowers', 'reserves', 'biblio', 'biblioitems', 'items'); >- } >- elsif ( $module eq 'acquisition' ) { >- push @{$field_selection}, add_fields('aqbooksellers', 'aqorders', 'biblio', 'items'); >- } >- elsif ($module eq 'claimacquisition' || $module eq 'orderacquisition') { >- push @{$field_selection}, add_fields('aqbooksellers', 'aqbasket', 'aqorders', 'biblio', 'biblioitems'); >- } >- elsif ($module eq 'claimissues') { >- push @{$field_selection}, add_fields('aqbooksellers', 'serial', 'subscription', 'biblio', 'biblioitems'); >- } >- elsif ( $module eq 'patron_slip' ) { >+ if ( $module eq 'reserves' ) { >+ push @{$field_selection}, add_fields( 'borrowers', 'reserves', 'biblio', 'biblioitems', 'items' ); >+ } elsif ( $module eq 'acquisition' ) { >+ push @{$field_selection}, add_fields( 'aqbooksellers', 'aqorders', 'biblio', 'items' ); >+ } elsif ( $module eq 'claimacquisition' || $module eq 'orderacquisition' ) { >+ push @{$field_selection}, add_fields( 'aqbooksellers', 'aqbasket', 'aqorders', 'biblio', 'biblioitems' ); >+ } elsif ( $module eq 'claimissues' ) { >+ push @{$field_selection}, add_fields( 'aqbooksellers', 'serial', 'subscription', 'biblio', 'biblioitems' ); >+ } elsif ( $module eq 'patron_slip' ) { > push @{$field_selection}, add_fields('borrowers'); >- } >- elsif ($module eq 'serial') { >- push @{$field_selection}, add_fields('branches', 'biblio', 'biblioitems', 'borrowers', 'subscription', 'serial'); >- } >- elsif ($module eq 'suggestions') { >- push @{$field_selection}, add_fields('suggestions', 'borrowers', 'biblio'); >- } >- else { >- push @{$field_selection}, add_fields('biblio','biblioitems'), >+ } elsif ( $module eq 'serial' ) { >+ push @{$field_selection}, >+ add_fields( 'branches', 'biblio', 'biblioitems', 'borrowers', 'subscription', 'serial' ); >+ } elsif ( $module eq 'suggestions' ) { >+ push @{$field_selection}, add_fields( 'suggestions', 'borrowers', 'biblio' ); >+ } else { >+ push @{$field_selection}, add_fields( 'biblio', 'biblioitems' ), > add_fields('items'), >- {value => 'items.content', text => 'items.content'}, >- {value => 'items.fine', text => 'items.fine'}, >+ { value => 'items.content', text => 'items.content' }, >+ { value => 'items.fine', text => 'items.fine' }, > add_fields('borrowers'); >- if ($module eq 'circulation') { >- push @{$field_selection}, add_fields('additional_contents', 'recalls'); >+ if ( $module eq 'circulation' ) { >+ push @{$field_selection}, add_fields( 'additional_contents', 'recalls' ); > > } > >@@ -278,7 +272,7 @@ sub add_form { > push @{$field_selection}, add_fields('issues'); > } > >- if ( $module eq 'circulation' and $code and $code =~ /^AR_/ ) { >+ if ( $module eq 'circulation' and $code and $code =~ /^AR_/ ) { > push @{$field_selection}, add_fields('article_requests'); > } > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32986
:
146750
|
148267
|
148361
|
148374
|
148376
|
149506
|
149507
|
153479
|
153480
|
153481
|
153482
|
156800
|
158399
|
158400
|
158401
|
158402
|
158403
|
158404
|
158405
|
158523