From 3342acaa360ebe00f09779f29cdc4841554671a0 Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 20 Jul 2023 02:39:27 +0000 Subject: [PATCH] Bug 30362: Fix GetSoonestRenewDate to really return soonest renew date This change fixes GetSoonestRenewDate so that it returns the soonest renew date as calculated using "No Renewal Before" and "NoRenewalBeforePrecision". In the past, it would only return the soonest renew date if "$now" was lesser than it, which would typically only happen when using an "exact" precision rather than a "date" precision. Test plan: 0. Apply the patch 1. prove t/db_dependent/Circulation.t --- C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 5a6e036685..98c66828f5 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -3457,7 +3457,7 @@ sub GetSoonestRenewDate { { $soonestrenewal->truncate( to => 'day' ); } - return $soonestrenewal if $now < $soonestrenewal; + return $soonestrenewal; } elsif ( $issue->auto_renew && $patron->autorenew_checkouts ) { # Checkouts with auto-renewing fall back to due date my $soonestrenewal = dt_from_string( $issue->date_due ); -- 2.30.2