Bugzilla – Attachment 153724 Details for
Bug 33964
Use Email::Sender::Transport::SMTP::Persistent for sending email
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33964: (QA follow-up) Handle absence of smtp server
Bug-33964-QA-follow-up-Handle-absence-of-smtp-serv.patch (text/plain), 1.22 KB, created by
Marcel de Rooy
on 2023-07-20 14:31:16 UTC
(
hide
)
Description:
Bug 33964: (QA follow-up) Handle absence of smtp server
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-07-20 14:31:16 UTC
Size:
1.22 KB
patch
obsolete
>From 0d815320b23eb40b750fd89f544e560c0eb19fff Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 20 Jul 2023 14:11:22 +0000 >Subject: [PATCH] Bug 33964: (QA follow-up) Handle absence of smtp server >Content-Type: text/plain; charset=utf-8 > >Resolve: >Use of uninitialized value in hash element at /usr/share/koha/C4/Letters.pm line 1472. >Use of uninitialized value in hash element at /usr/share/koha/C4/Letters.pm line 1473. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Letters.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index e190f90c08..e070697df4 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -1469,8 +1469,8 @@ sub _send_message_by_email { > if !$message->{to_address} > || $message->{to_address} ne $email->email->header('To'); > >- $smtp_transports->{ $smtp_server->id } ||= $smtp_server->transport; >- my $smtp_transport = $smtp_transports->{ $smtp_server->id }; >+ $smtp_transports->{ $smtp_server->id // 'default' } ||= $smtp_server->transport; >+ my $smtp_transport = $smtp_transports->{ $smtp_server->id // 'default' }; > > try { > $email->send_or_die({ transport => $smtp_transport }); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33964
:
152211
|
153101
|
153723
| 153724 |
153857
|
153869