Bugzilla – Attachment 153832 Details for
Bug 34351
ILL list table - access_url column content should be clickable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34351: Add link to access_url
Bug-34351-Add-link-to-accessurl.patch (text/plain), 1.37 KB, created by
Pedro Amorim
on 2023-07-24 10:24:03 UTC
(
hide
)
Description:
Bug 34351: Add link to access_url
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-07-24 10:24:03 UTC
Size:
1.37 KB
patch
obsolete
>From 8ad1812b1c7126875ec536b517ad8c494864c617 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 24 Jul 2023 10:23:41 +0000 >Subject: [PATCH] Bug 34351: Add link to access_url > >On k-t-d >1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) >2) Create a new Freeform request >3) Update access_url field. Run this mysql query: >update illrequests set accessurl = https://koha-community.org/; >4) Visit ill table list at /cgi-bin/koha/ill/ill-requests.pl >5) Verify access url is not clickable >6) Apply patch. Refresh. Verify it's now clickable. >--- > koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >index 9419b0fa5d..801143cf57 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >@@ -334,7 +334,8 @@ $(document).ready(function() { > "data": "access_url", > "orderable": true, > "render": function(data, type, row, meta) { >- return escape_str(data); >+ return '<a target="_blank" href="' + data + '">' >+ + escape_str(data) + '</a>'; > } > }, > { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34351
:
153832
|
153848
|
154115