@@ -, +, @@ iterator --- Koha/Item.pm | 5 ++--- t/db_dependent/Koha/Item.t | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) --- a/Koha/Item.pm +++ a/Koha/Item.pm @@ -891,9 +891,8 @@ This method checks the tmp_holdsqueue to see if this item has been selected for =cut sub has_pending_hold { - my ( $self ) = @_; - my $pending_hold = $self->_result->tmp_holdsqueues; - return $pending_hold->count ? 1: 0; + my ($self) = @_; + return $self->_result->tmp_holdsqueue ? 1 : 0; } =head3 has_pending_recall { --- a/t/db_dependent/Koha/Item.t +++ a/t/db_dependent/Koha/Item.t @@ -364,6 +364,7 @@ subtest 'has_pending_hold() tests' => sub { $dbh->do("INSERT INTO tmp_holdsqueue (surname,borrowernumber,itemnumber) VALUES ('Clamp',42,$itemnumber)"); ok( $item->has_pending_hold, "Yes, we have a pending hold"); $dbh->do("DELETE FROM tmp_holdsqueue WHERE itemnumber=$itemnumber"); + $item->discard_changes; ok( !$item->has_pending_hold, "We don't have a pending hold if nothing in the tmp_holdsqueue"); $schema->storage->txn_rollback; --