From fe9c1b72eeb89369d2a46a9248f351e14f951fe8 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 4 Aug 2023 15:05:38 +0200 Subject: [PATCH] Bug 34417: [ALTERNATIVE PATCH] Set entity's name from the component itself I would have preferred to not modify the component to pass what we have fetched, but I think it's cleaner than hacking the low level fetch function. This is just a POC and work only on the "show agreement" view --- .../prog/js/vue/components/Breadcrumbs.vue | 5 +++++ .../js/vue/components/ERM/AgreementsShow.vue | 1 + .../prog/js/vue/components/ERM/Main.vue | 10 +++++++-- .../prog/js/vue/components/NavigationItem.vue | 21 +++++++++++++++++++ .../intranet-tmpl/prog/js/vue/routes/erm.js | 2 +- 5 files changed, 36 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Breadcrumbs.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Breadcrumbs.vue index 9d2b74db0c4..bfad7fc95d7 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Breadcrumbs.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Breadcrumbs.vue @@ -6,6 +6,7 @@ v-if="idx < breadcrumbs.length - 1" :item="item" :params="params" + :args="args" > @@ -40,6 +42,9 @@ export default { components: { NavigationItem, }, + props: { + args: Object, + }, } diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue index 34e77e98b8d..cd227c5913b 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue @@ -387,6 +387,7 @@ export default { client.agreements.get(agreement_id).then( agreement => { this.agreement = agreement + this.$root.set_breadcrumb({ agreement: this.agreement }) this.initialized = true }, error => {} diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue index 12e569e28d6..6b097eaad56 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue @@ -1,7 +1,7 @@ diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js index 39eea67c417..c388904a712 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js @@ -60,7 +60,7 @@ export const routes = [ path: ":agreement_id", name: "AgreementsShow", component: markRaw(AgreementsShow), - title: $__("Show agreement"), + title: $__("Show {agreement.name}"), children: [ { path: "items", -- 2.25.1