From 4d42c8bf9dee508ae6908bf3142ddfefa4a7648b Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Wed, 12 Jun 2019 11:43:48 +0000
Subject: [PATCH] Bug 23102: 404 errors on page causes SCI user to be logged
 out

To test:
 1 - Have something on the SCO page that won't load
 2 - Add the self_checkin_module and self_checkout_module permissions to the AutoSelfCheck user
 3 - Access the selfcheckout module https://yoursite.org/cgi-bin/koha/sco/sco-main.pl
 4 - Sign in using a patron
 5 - Enter an unkown barcode, I used "DONTMATTER"
 6 - If not logged out, click to 'Return to account summary'
 7 - You are asked to sign in again
 8 - Repeat with the SCI module
 9 - Apply patch
10 - Repeat, but this time you can return to account
---
 C4/Auth.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/C4/Auth.pm b/C4/Auth.pm
index 9b298eed87..6b07c866e8 100644
--- a/C4/Auth.pm
+++ b/C4/Auth.pm
@@ -236,7 +236,7 @@ sub get_template_and_user {
 # If the user logged in is the SCI user and they try to go out of the SCI module,
 # kick them out unless it is SCO with a valid permission
 # or they are a superlibrarian
-               $in->{template_name} !~ m|sci/|
+            $in->{template_name} !~ m|sci/| && $in->{template_name} !~ m|errors/errorpage.tt|
             && haspermission( $user, { self_check => 'self_checkin_module' } )
             && !(
                 $in->{template_name} =~ m|sco/| && haspermission(
-- 
2.30.2