Bugzilla – Attachment 154694 Details for
Bug 33919
Improve translation of title tags: Patron clubs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33919: Improve translation of title tags: Patron clubs
Bug-33919-Improve-translation-of-title-tags-Patron.patch (text/plain), 6.42 KB, created by
Owen Leonard
on 2023-08-22 13:39:19 UTC
(
hide
)
Description:
Bug 33919: Improve translation of title tags: Patron clubs
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2023-08-22 13:39:19 UTC
Size:
6.42 KB
patch
obsolete
>From 40ed258ede7c27fc056f41e23b8927a6c48edfdd Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 6 Jun 2023 15:14:31 +0000 >Subject: [PATCH] Bug 33919: Improve translation of title tags: Patron clubs > >This patch updates patron clubs templates so that title tags can be more >easily translated. > >The patch also makes some minor changes to some templates to improve >consistency between page title, breadcrumb navigation, and page heading. > >To test, apply the patch and confirm that the following pages have the >correct title tags: > >- Tools -> Patron clubs > - New and Edit club template > - New and Edit club > - Club enrollments (from the list of clubs choose Actions -> > Enrollments) >--- > .../prog/en/modules/clubs/club-enrollments.tt | 15 ++++++++++----- > .../prog/en/modules/clubs/clubs-add-modify.tt | 14 +++++++++----- > .../prog/en/modules/clubs/clubs.tt | 7 ++++++- > .../en/modules/clubs/templates-add-modify.tt | 18 +++++++++++------- > 4 files changed, 36 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt >index 8bd3e534da..252f219d8f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt >@@ -3,11 +3,16 @@ > [% USE KohaDates %] > [% USE Branches %] > [% USE Koha %] >-[% USE AuthorisedValues %] >-[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %] >+[% USE HtmlTags %] >+[% PROCESS 'i18n.inc' %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >-<title>Club enrollments › Patron clubs › Tools › Koha</title> >+<title>[% FILTER collapse %] >+ [% tx("Club enrollments for {club_name}", { club_name = club.name }) | html %] › >+ [% t("Patron clubs") | html %] › >+ [% t("Tools") | html %] › >+ [% t("Koha") | html %] >+[% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] > </head> > >@@ -25,7 +30,7 @@ > <a href="clubs.pl">Patron clubs</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- <span>Club enrollments</span> >+ <span>Club enrollments for [% club.name | html | $HtmlTags tag="em" %]</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >@@ -37,7 +42,7 @@ > [% IF !club %] > <div class="dialog message">The club you requested does not exist.</div> > [% ELSE %] >- <h1>Club enrollments for <em>[% club.name | html %]</em></h1> >+ <h1>Club enrollments for [% club.name | html | $HtmlTags tag="em" %]</h1> > > <div class="page-section"> > <table id="enrollments-table"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt >index ebbb27897a..3be9e0407c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt >@@ -3,15 +3,19 @@ > [% USE KohaDates %] > [% USE Branches %] > [% USE AuthorisedValues %] >+[% PROCESS 'i18n.inc' %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >-<title> >+<title>[% FILTER collapse %] > [% IF club %] >- Modify club [% club.name | html %] >+ [% tx("Modify club {club_name}", { club_name = club.name }) | html %] > [% ELSE %] >- Create a new [% club_template.name | html %] club >- [% END %] › Patron clubs › Tools › Koha >-</title> >+ [% tx("Create a new {club_template} club", { club_template = club_template.name }) | html %] >+ [% END %] › >+ [% t("Patron clubs") | html %] › >+ [% t("Tools") | html %] › >+ [% t("Koha") | html %] >+[% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] > </head> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt >index dd7c26a781..aa8076a6db 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt >@@ -3,9 +3,14 @@ > [% USE KohaDates %] > [% USE Branches %] > [% USE Koha %] >+[% PROCESS 'i18n.inc' %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >-<title>Patron clubs › Tools › Koha</title> >+<title>[% FILTER collapse %] >+ [% t("Patron clubs") | html %] › >+ [% t("Tools") | html %] › >+ [% t("Koha") | html %] >+[% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] > > </head> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt >index bb4d3e5738..e3341bfc03 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt >@@ -2,15 +2,19 @@ > [% USE Branches %] > [% USE AuthorisedValues %] > [% USE HtmlTags %] >+[% PROCESS 'i18n.inc' %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >-<title> >+<title>[% FILTER collapse %] > [% IF club_template %] >- Modify club template [% club_template.name | html %] >+ [% tx("Modify club template {club_template}", { club_template = club_template.name }) | html %] › > [% ELSE %] >- Create a new club template >- [% END %] › Patron clubs › Tools › Koha >-</title> >+ [% t("New club template") | html %] >+ [% END %] › >+ [% t("Patron clubs") | html %] › >+ [% t("Tools") | html %] › >+ [% t("Koha") | html %] >+[% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] > <style> > .club-field, >@@ -37,7 +41,7 @@ > [% IF club_template %] > <span>Modify club template [% club_template.name | html | $HtmlTags tag="em" %]</span> > [% ELSE %] >- <span>Create a new club template</span> >+ <span>New club template</span> > [% END %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] >@@ -54,7 +58,7 @@ > [% IF club_template %] > <span>Modify club template [% club_template.name | html | $HtmlTags tag="em" %]</span> > [% ELSE %] >- <span>Create a new club template</span> >+ <span>New club template</span> > [% END %] > </h1> > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33919
:
154694
|
155569
|
156024