Bugzilla – Attachment 154702 Details for
Bug 34589
Update on bug 20256 is not idempotent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34589: Only update users if permission is added
Bug-34589-Only-update-users-if-permission-is-added.patch (text/plain), 1.85 KB, created by
Nick Clemens (kidclamp)
on 2023-08-22 15:09:52 UTC
(
hide
)
Description:
Bug 34589: Only update users if permission is added
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-08-22 15:09:52 UTC
Size:
1.85 KB
patch
obsolete
>From 1a60897bd3dfb055dab2415d47c0bd35b9e2fd47 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 22 Aug 2023 15:09:17 +0000 >Subject: [PATCH] Bug 34589: Only update users if permission is added > >--- > installer/data/mysql/db_revs/221200003.pl | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) > >diff --git a/installer/data/mysql/db_revs/221200003.pl b/installer/data/mysql/db_revs/221200003.pl >index 2df9e03d06..672e9cc674 100755 >--- a/installer/data/mysql/db_revs/221200003.pl >+++ b/installer/data/mysql/db_revs/221200003.pl >@@ -7,18 +7,22 @@ return { > my ($args) = @_; > my ($dbh, $out) = @$args{qw(dbh out)}; > >- $dbh->do(q{ >+ my $permission_added = $dbh->do(q{ > INSERT IGNORE INTO permissions (module_bit, code, description) VALUES ( 9, 'edit_any_item', 'Edit any item reguardless of home library'); > }); >- say $out "Added new permission 'edit_any_item'"; > >- $dbh->do(q{ >- INSERT IGNORE INTO user_permissions ( borrowernumber, module_bit, code ) >- SELECT borrowernumber, '9', 'edit_any_item' >- FROM user_permissions >- WHERE module_bit = '9' >- AND code = 'edit_items' >- }); >+ if( $permission_added == 1 ){ >+ say $out "Added new permission 'edit_any_item'"; >+ >+ $dbh->do(q{ >+ INSERT IGNORE INTO user_permissions ( borrowernumber, module_bit, code ) >+ SELECT borrowernumber, '9', 'edit_any_item' >+ FROM user_permissions >+ WHERE module_bit = '9' >+ AND code = 'edit_items' >+ }); >+ say $out "Added 'edit_any_item' permission to users with edit items permission"; >+ } > > if ( !column_exists( 'library_groups', 'ft_limit_item_editing' ) ) { > $dbh->do(q{ >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34589
:
154702
|
155271
|
155501
|
155634