From 7e760f07461a41fb1fd125b04e612b7bc3b7b47d Mon Sep 17 00:00:00 2001 From: Lucas Gass <lucas@bywatersolutions.com> Date: Thu, 17 Aug 2023 17:25:56 +0000 Subject: [PATCH] Bug 34356: Make sort order always default to correct column To test: 1- Check out an item to a patron 2- View checkout history, default sort is on 'Date due' 3- Enable RecordStaffUserOnCheckout 4- View checkout history, default sort is on 'Checked out by' 5- Apply patch 6- Table should sort to 'Date due' no matter what the sys pref is set to Signed-off-by: Jason <jrobb@sekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> --- .../intranet-tmpl/prog/en/modules/members/readingrec.tt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt index ec4c5dfdb9..f93fae1117 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt @@ -174,10 +174,15 @@ [% Asset.js("js/checkout_renewals_modal.js") | $raw %] <script id="js"> $(document).ready(function() { + [% IF Koha.Preference('RecordStaffUserOnCheckout') %] + var column_sort = 11; + [% ELSE %] + var column_sort = 10; + [% END %] var table_settings = [% TablesSettings.GetTableSettings('members', 'checkouthistory', 'checkouthistory-table', 'json') | $raw %]; var table = KohaTable("table_readingrec", { "sPaginationType": "full", - "aaSorting": [[10, 'desc']] + "aaSorting": [[column_sort, 'desc']] }, table_settings); $("#tabs a[data-toggle='tab']").on("shown.bs.tab", function (e) { -- 2.30.2