From a2ae4d805673f73b2568509397c09d979ac4f7f1 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 25 Aug 2023 08:02:15 +0000 Subject: [PATCH] Bug 33537: (QA follow-up) Resolve forbidden pattern in REST API Resolving: FAIL Koha/REST/V1/Config/SMTP/DomainLimits.pm FAIL forbidden patterns forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 57) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 75) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 103) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 106) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 133) Test plan: Run t/db_dependent/api/v1/domain_limits.t Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim --- Koha/REST/V1/Config/SMTP/DomainLimits.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Koha/REST/V1/Config/SMTP/DomainLimits.pm b/Koha/REST/V1/Config/SMTP/DomainLimits.pm index 9a4c3b47c1..7d3cce02e0 100644 --- a/Koha/REST/V1/Config/SMTP/DomainLimits.pm +++ b/Koha/REST/V1/Config/SMTP/DomainLimits.pm @@ -53,7 +53,7 @@ Controller method that handles retrieving a single domain limit sub get { my $c = shift->openapi->valid_input or return; return try { - my $rec = Koha::MailDomainLimits->search_with_group_domain->find( $c->validation->param('domain_limit_id') ); + my $rec = Koha::MailDomainLimits->search_with_group_domain->find( $c->param('domain_limit_id') ); return $c->render( _render_helper( 404, undef, error => "Domain limit not found" ) ) if !$rec; return $c->render( _render_helper( 200, undef, result => $rec->to_api ) ); } catch { @@ -70,7 +70,7 @@ Controller method that handles adding a new domain limit sub add { my $c = shift->openapi->valid_input or return; return try { - my $limit = Koha::MailDomainLimit->new_from_api( $c->validation->param('body') ); + my $limit = Koha::MailDomainLimit->new_from_api( $c->req->json ); $limit->store->discard_changes; $c->res->headers->location( $c->req->url->to_string . '/' . $limit->id ); return $c->render( _render_helper( 201, undef, result => $limit->to_api ) ); @@ -97,10 +97,10 @@ Controller method that handles updating a domain limit sub update { my $c = shift->openapi->valid_input or return; - my $limit = Koha::MailDomainLimits->find( $c->validation->param('domain_limit_id') ); + my $limit = Koha::MailDomainLimits->find( $c->param('domain_limit_id') ); return $c->render( _render_helper( 404, undef, error => "Object not found" ) ) if !$limit; return try { - $limit->set_from_api( $c->validation->param('body') ); + $limit->set_from_api( $c->req->json ); $limit->store->discard_changes; return $c->render( _render_helper( 200, undef, result => $limit->to_api ) ); } catch { @@ -126,7 +126,7 @@ Controller method that handles deleting a domain limit sub delete { my $c = shift->openapi->valid_input or return; - my $limit = Koha::MailDomainLimits->find( $c->validation->param('domain_limit_id') ); + my $limit = Koha::MailDomainLimits->find( $c->param('domain_limit_id') ); return $c->render( _render_helper( 404, undef, error => "Domain limit not found" ) ) if !$limit; return try { $limit->delete; -- 2.30.2