From 8a36cf425c9fe9399ed634d8509c05e5ef189624 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 28 Aug 2023 12:26:51 +0000 Subject: [PATCH] Bug 34625: Fix search engine configuration tables header problem This patch corrects the JavaScript which allows DataTables to be created and destroyed based on which tab is clicked on the search engine configuration page. When you click from one tab to the other, the original tab's DataTable should be destroyed and the new tab's DataTable initialized. To test, apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - The page should load with the "Search fields" tab enabled and the DataTable initialized: Sorting and filtering should work. If you scroll down the page the floating table header should be correct. - Switch to the "Bibliographic records" tab. This table should have filtering enabled, and the floating table header should work when you scroll down the page. - The same should be true for the "Authorities" tab. - Return to the "Search fields" tab to confirm that the DataTable is still working as expected. --- koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js b/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js index cf1faa9519..8bead3c010 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js +++ b/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js @@ -42,8 +42,8 @@ $(document).ready(function () { tableInit( "", "search_fields"); $("a[data-toggle='tab']").on("shown.bs.tab", function (e) { - var oldtabid = $(e.relatedTarget).data("tab"); - var newtabid = $(e.target).data("tab"); + var oldtabid = $(e.relatedTarget).data("tabname"); + var newtabid = $(e.target).data("tabname"); tableInit( oldtabid, newtabid ); }); -- 2.30.2