From 4de4722a98c82ccd1a9eaceddb05168d4fca44bd Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 31 Aug 2023 17:05:57 +0200 Subject: [PATCH] Bug 34684: Prevent 220600007.pl to fail if run twice The error is ERROR 1292 (22007): Truncated incorrect DECIMAL value: 'no' Happens on MariaDB 10.5.22, not MySQL 8 Test plan: update systempreferences set value="0" where variable="DisplayClearScreenButton"; play installer/data/mysql/db_revs/220600007.pl select value from systempreferences where variable="DisplayClearScreenButton"; => "no" update systempreferences set value="1" where variable="DisplayClearScreenButton"; play installer/data/mysql/db_revs/220600007.pl select value from systempreferences where variable="DisplayClearScreenButton"; => "issueslip" --- installer/data/mysql/db_revs/220600007.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/installer/data/mysql/db_revs/220600007.pl b/installer/data/mysql/db_revs/220600007.pl index 8fc89a37d8d..8e8a786c1f7 100755 --- a/installer/data/mysql/db_revs/220600007.pl +++ b/installer/data/mysql/db_revs/220600007.pl @@ -13,7 +13,7 @@ return { options = 'no|issueslip|issueqslip', type = 'Choice', value = CASE value - WHEN 1 THEN 'issueslip' + WHEN "1" THEN 'issueslip' ELSE 'no' END WHERE variable = 'DisplayClearScreenButton'; -- 2.25.1