Bugzilla – Attachment 155276 Details for
Bug 34684
220600007.pl is failing if run twice
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34684: Prevent 220600007.pl to fail if run twice
Bug-34684-Prevent-220600007pl-to-fail-if-run-twice.patch (text/plain), 1.67 KB, created by
Marcel de Rooy
on 2023-09-06 14:36:28 UTC
(
hide
)
Description:
Bug 34684: Prevent 220600007.pl to fail if run twice
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-09-06 14:36:28 UTC
Size:
1.67 KB
patch
obsolete
>From 6d8b3df9255caa3593b814c33d421be751eb3502 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 31 Aug 2023 17:05:57 +0200 >Subject: [PATCH] Bug 34684: Prevent 220600007.pl to fail if run twice >Content-Type: text/plain; charset=utf-8 > >The error is > ERROR 1292 (22007): Truncated incorrect DECIMAL value: 'no' > >Happens on MariaDB 10.5.22, not MySQL 8 > >Test plan: >update systempreferences set value="0" where variable="DisplayClearScreenButton"; >play installer/data/mysql/db_revs/220600007.pl >select value from systempreferences where variable="DisplayClearScreenButton"; >=> "no" > >update systempreferences set value="1" where variable="DisplayClearScreenButton"; >play installer/data/mysql/db_revs/220600007.pl >select value from systempreferences where variable="DisplayClearScreenButton"; >=> "issueslip" > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > installer/data/mysql/db_revs/220600007.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/installer/data/mysql/db_revs/220600007.pl b/installer/data/mysql/db_revs/220600007.pl >index 8fc89a37d8..8e8a786c1f 100755 >--- a/installer/data/mysql/db_revs/220600007.pl >+++ b/installer/data/mysql/db_revs/220600007.pl >@@ -13,7 +13,7 @@ return { > options = 'no|issueslip|issueqslip', > type = 'Choice', > value = CASE value >- WHEN 1 THEN 'issueslip' >+ WHEN "1" THEN 'issueslip' > ELSE 'no' > END > WHERE variable = 'DisplayClearScreenButton'; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34684
:
155056
|
155275
| 155276