Bugzilla – Attachment 155583 Details for
Bug 33734
Using custom search filters breaks diacritics characters in search term
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33734: Remove incorrect URL escaping on search filters
Bug-33734-Remove-incorrect-URL-escaping-on-search-.patch (text/plain), 2.07 KB, created by
PTFS Europe Sandboxes
on 2023-09-13 06:16:49 UTC
(
hide
)
Description:
Bug 33734: Remove incorrect URL escaping on search filters
Filename:
MIME Type:
Creator:
PTFS Europe Sandboxes
Created:
2023-09-13 06:16:49 UTC
Size:
2.07 KB
patch
obsolete
>From b818288d82b1d264e220438ea080bf75c95208d1 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Wed, 13 Sep 2023 02:25:13 +0000 >Subject: [PATCH] Bug 33734: Remove incorrect URL escaping on search filters >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch removes an incorrect URL escaping on search filter >facet URLs. > >Without this patch, search filters using non-ASCII characters won't >return results. > >To test: >0. Apply patch >1. Enable SavedSearchFilters syspref >2. Search for "the" >3. Save as search filter >4. Search for "ü" >5. Apply the "the" filter >6. Note that search results appear > >Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >index 3e708036f6..0dc74bbe9f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >@@ -13,11 +13,12 @@ > <ul> > [% SET base_url = "/cgi-bin/koha/catalogue/search.pl?" _ query_cgi _ limit_cgi %] > [% FOREACH search_filter IN search_filters %] >+ [% SET search_filter_id = search_filter.id | uri %] > <li> > [% IF active_filters.${search_filter.id} %] >- <span class="filter_label">[% search_filter.name | html %]<a href="[% base_url _ '&nolimit=search_filter:' _ search_filter.id | url %]">[x]</a></span> >+ <span class="filter_label">[% search_filter.name | html %]<a href="[% base_url _ '&nolimit=search_filter:' _ search_filter_id | $raw %]">[x]</a></span> > [% ELSE %] >- <span class="filter_label"><a href="[% base_url _ '&limit=search_filter:' _ search_filter.id | url %]">[% search_filter.name | html %]</a></span> >+ <span class="filter_label"><a href="[% base_url _ '&limit=search_filter:' _ search_filter_id | $raw %]">[% search_filter.name | html %]</a></span> > [% END %] > </li> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33734
:
151551
|
151653
|
155582
|
155583
|
155584
|
155585
|
155690