Bugzilla – Attachment 155760 Details for
Bug 34711
Remove use of onclick for opac-privacy.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34711: Remove use of onclick for opac-privacy.pl
Bug-34711-Remove-use-of-onclick-for-opac-privacypl.patch (text/plain), 4.24 KB, created by
Katrin Fischer
on 2023-09-17 14:32:52 UTC
(
hide
)
Description:
Bug 34711: Remove use of onclick for opac-privacy.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-09-17 14:32:52 UTC
Size:
4.24 KB
patch
obsolete
>From 9814e02eb8e38f308cf75dd8faf179c36b357cfb Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 5 Sep 2023 04:58:52 +0000 >Subject: [PATCH] Bug 34711: Remove use of onclick for opac-privacy.pl > >This change removes the "onclick" attribute for the buttons >on opac-privacy.pl. > >Note: The Javascript is placed in a separate file, which is >the preferred way for Javascript to be handled by >Content-Security-Policy > >Test plan: >0. Apply the patch >1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OPACPrivacy >2. Set syspref to "Allow" >3. Go to http://localhost:8080/cgi-bin/koha/opac-privacy.pl >4. The confirmation modal appears and "OK" and "Cancel" buttons work as > expected > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 10 ++++++---- > koha-tmpl/opac-tmpl/bootstrap/js/privacy.js | 5 +++++ > 2 files changed, 11 insertions(+), 4 deletions(-) > create mode 100644 koha-tmpl/opac-tmpl/bootstrap/js/privacy.js > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt >index 1d3c155f08..f3af3f48d5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt >@@ -175,7 +175,7 @@ > <td colspan=7>Immediately delete my checkout history. This action cannot be undone.</td> > <td colspan=1> > <fieldset class="action"> >- <input type="submit" value="Delete checkout history" form="opac-privacy-delete-checkouts" class="btn btn-danger btn-block" onclick="return confirmDelete(MSG_CONFIRM_AGAIN);" /> >+ <input type="submit" value="Delete checkout history" form="opac-privacy-delete-checkouts" class="btn btn-danger btn-block privacy-confirm-delete" /> > </fieldset> > </td> > </tr> >@@ -183,7 +183,7 @@ > <td colspan=7>Immediately delete my hold history. This action cannot be undone.</td> > <td colspan=1> > <fieldset class="action"> >- <input type="submit" value="Delete hold history" form="opac-privacy-delete-holds" class="btn btn-danger btn-block" onclick="return confirmDelete(MSG_CONFIRM_AGAIN);" /> >+ <input type="submit" value="Delete hold history" form="opac-privacy-delete-holds" class="btn btn-danger btn-block privacy-confirm-delete" /> > </fieldset> > </td> > </tr> >@@ -191,7 +191,7 @@ > <td colspan=7>Immediately delete my checkout history & my hold history. This action cannot be undone.</td> > <td colspan=1> > <fieldset class="action"> >- <input type="submit" value="Delete checkout and hold history" form="opac-privacy-delete-all" class="btn btn-danger btn-block" onclick="return confirmDelete(MSG_CONFIRM_AGAIN);" /> >+ <input type="submit" value="Delete checkout and hold history" form="opac-privacy-delete-all" class="btn btn-danger btn-block privacy-confirm-delete" /> > </fieldset> > </td> > </tr> >@@ -208,4 +208,6 @@ > </div> <!-- / .main --> > > [% INCLUDE 'opac-bottom.inc' %] >-[% BLOCK jsinclude %][% END %] >+[% BLOCK jsinclude %] >+ [% Asset.js('js/privacy.js') | $raw %] >+[% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/privacy.js b/koha-tmpl/opac-tmpl/bootstrap/js/privacy.js >new file mode 100644 >index 0000000000..f2eeb89983 >--- /dev/null >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/privacy.js >@@ -0,0 +1,5 @@ >+$(document).ready(function(){ >+ $('.privacy-confirm-delete').on('click',function(){ >+ return confirmDelete(MSG_CONFIRM_AGAIN); >+ }); >+}); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34711
:
155210
|
155214
| 155760