From 69beb6192736ed1a5bf57e0b81c4d20b90287cd4 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 25 Sep 2023 11:39:22 +0100 Subject: [PATCH] Bug 34737: (follow-up) Unit test for skipping bad lines We update the test rules set to include some malformed, empty and comment lines. No actual tests are added, but the skipping is checked by all other tests in this way. --- t/db_dependent/SIP/Transaction.t | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t index 54b77b2cdf5..46e661f2c81 100755 --- a/t/db_dependent/SIP/Transaction.t +++ b/t/db_dependent/SIP/Transaction.t @@ -981,7 +981,11 @@ subtest _get_sort_bin => sub { my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); my $branch2 = $library2->branchcode; + # Rules starts with malformed line, empty line and a comment to prove they are skipped my $rules = <<"RULES"; +$branch:homebranch:Z\r + +# Comment line $branch:homebranch:ne:\$holdingbranch:X\r $branch:effective_itemtype:eq:CD:0\r $branch:itemcallnumber:<:340:1\r -- 2.41.0