From a0bbc89ab4e3e57f412a7b27f18eeb80c04ea3be Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Fri, 29 Sep 2023 13:49:47 +0000 Subject: [PATCH] Bug 29145: (QA follow-up) Fix tests removing 'unblessed' This fixes issues with the tests caused by: Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm --- t/db_dependent/Circulation/MarkIssueReturned.t | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/t/db_dependent/Circulation/MarkIssueReturned.t b/t/db_dependent/Circulation/MarkIssueReturned.t index 57b9820857..9c43132a25 100755 --- a/t/db_dependent/Circulation/MarkIssueReturned.t +++ b/t/db_dependent/Circulation/MarkIssueReturned.t @@ -203,7 +203,7 @@ subtest 'AutoRemoveOverduesRestrictions' => sub { my $item_1 = $builder->build_sample_item; my $item_2 = $builder->build_sample_item; my $item_3 = $builder->build_sample_item; - my $nine_days_ago = dt_from_string->subtract( days => 9 ); + my $nine_days_ago = dt_from_string->subtract( days => 9 ); my $checkout_1 = AddIssue( $patron, $item_1->barcode, $nine_days_ago ); # overdue, but would not trigger debarment my $checkout_2 = @@ -234,9 +234,9 @@ subtest 'AutoRemoveOverduesRestrictions' => sub { my $ten_days_ago = dt_from_string->subtract( days => 10 ); - $checkout_1 = AddIssue( $patron->unblessed, $item_1->barcode, $ten_days_ago ); # overdue and would trigger debarment + $checkout_1 = AddIssue( $patron, $item_1->barcode, $ten_days_ago ); # overdue and would trigger debarment $checkout_2 = - AddIssue( $patron->unblessed, $item_2->barcode, $nine_days_ago ); # overdue, but would not trigger debarment + AddIssue( $patron, $item_2->barcode, $nine_days_ago ); # overdue, but would not trigger debarment Koha::Patron::Debarments::AddUniqueDebarment( { @@ -254,7 +254,7 @@ subtest 'AutoRemoveOverduesRestrictions' => sub { 'OVERDUES debarment is removed if remaining items would not result in patron debarment' ); - $checkout_1 = AddIssue( $patron->unblessed, $item_1->barcode, $ten_days_ago ); # overdue and would trigger debarment + $checkout_1 = AddIssue( $patron, $item_1->barcode, $ten_days_ago ); # overdue and would trigger debarment Koha::Patron::Debarments::AddUniqueDebarment( { @@ -275,7 +275,7 @@ subtest 'AutoRemoveOverduesRestrictions' => sub { my $eleven_days_ago = dt_from_string->subtract( days => 11 ); # overdue and would trigger debarment - $checkout_2 = AddIssue( $patron->unblessed, $item_2->barcode, $eleven_days_ago ); + $checkout_2 = AddIssue( $patron, $item_2->barcode, $eleven_days_ago ); # $checkout_1 should now not trigger debarment with this new rule for specific branchcode $dbh->do( -- 2.30.2