Bugzilla – Attachment 156765 Details for
Bug 35015
Regression: Charges table no longer filters out paid transactions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35015: Adjust column index in fnFilter
Bug-35015-Adjust-column-index-in-fnFilter.patch (text/plain), 1.85 KB, created by
Katrin Fischer
on 2023-10-09 20:00:40 UTC
(
hide
)
Description:
Bug 35015: Adjust column index in fnFilter
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-10-09 20:00:40 UTC
Size:
1.85 KB
patch
obsolete
>From d89e5c06549ec463dec66ece65eae2cb7bb7c9a6 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Mon, 9 Oct 2023 16:11:48 +0000 >Subject: [PATCH] Bug 35015: Adjust column index in fnFilter > >This patch fixes the column index in the call to fnFilter following the >addition of a new column to the table in bug 32341 > >Test plan: >1) Add some charges to a patron account >2) Pay some of these charges so that they are no longer outstanding >3) In the OPAC log in as that patron and navigate to the Charges tab in > their account >4) Observe that all charges are listed, even if they have been paid and > clicking the Show all transactions button has no effect even if > clicked multiple times between the different filtering options >5) Apply patch >6) Refresh page and now the settled charges should be filtered out >7) Click the Show all transactions button and it should correctly update > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt >index adf358c116..3d80b71b9d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt >@@ -137,7 +137,7 @@ $( document ).ready(function() { > var filteredValue = '^((?!0.00).*)$'; //Filter not matching 0.00 http://stackoverflow.com/a/406408 > $(this).html('<i class="fa fa-filter" aria-hidden="true"></i> '+txtInactivefilter); > } >- fines_table.fnFilter(filteredValue, -1, true, false); >+ fines_table.fnFilter(filteredValue, -2, true, false); > $(this).toggleClass('filtered'); > }); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35015
:
156755
|
156756
|
156764
| 156765 |
156766
|
156784