Bugzilla – Attachment 156838 Details for
Bug 25393
Create separate 'no automatic renewal before' rule
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25393: (QA follow-up) Report 'too_soon' errors from cron
Bug-25393-QA-follow-up-Report-toosoon-errors-from-.patch (text/plain), 1.29 KB, created by
Nick Clemens (kidclamp)
on 2023-10-11 14:56:42 UTC
(
hide
)
Description:
Bug 25393: (QA follow-up) Report 'too_soon' errors from cron
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-10-11 14:56:42 UTC
Size:
1.29 KB
patch
obsolete
>From a91d9be14e594786bc9e515336373914d500d914 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 11 Oct 2023 13:55:42 +0000 >Subject: [PATCH] Bug 25393: (QA follow-up) Report 'too_soon' errors from cron > >This patchset made it possible for 'too_soon' to be returned instead of 'auto_too_soon' - we just need to take that into account in the error listing > >To test: >1 - Set circ rule to no renewal before 2, no auto renewal before 3 >2 - Checkout 3 items with auto renew, due tomorrow, in 2 days, in 3 days >3 - perl misc/cronjobs/automatic_renewals.pl -v >4 - Confirm 1 can be renewed, 1 is too soon, 1 is auto too soon > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > misc/cronjobs/automatic_renewals.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/misc/cronjobs/automatic_renewals.pl b/misc/cronjobs/automatic_renewals.pl >index 4fa83566a8..8115afee7c 100755 >--- a/misc/cronjobs/automatic_renewals.pl >+++ b/misc/cronjobs/automatic_renewals.pl >@@ -205,6 +205,7 @@ while ( my $auto_renew = $auto_renews->next ) { > $error eq 'auto_too_late' || > $error eq 'auto_too_much_oweing' || > $error eq 'auto_too_soon' || >+ $error eq 'too_soon' || > $error eq 'item_denied_renewal' || > $error eq 'item_issued_to_other_patron' > ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25393
:
154533
|
154534
|
154535
|
154536
|
154537
|
154538
|
154539
|
154540
|
154541
|
154661
|
154662
|
154663
|
154664
|
154665
|
154666
|
154667
|
154668
|
154669
|
155307
|
155308
|
155309
|
155310
|
155311
|
155312
|
155313
|
155314
|
155315
|
156829
|
156830
|
156831
|
156832
|
156833
|
156834
|
156835
|
156836
|
156837
| 156838 |
156839
|
156840