Bugzilla – Attachment 156982 Details for
Bug 34908
Sort item types alphabetically by description rather than code when adding a new empty record as an order to a basket
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34908: Sort item types alphabetically by description when adding a new empty record as an order to a basket
Bug-34908-Sort-item-types-alphabetically-by-descri.patch (text/plain), 1.65 KB, created by
Nick Clemens (kidclamp)
on 2023-10-12 15:27:32 UTC
(
hide
)
Description:
Bug 34908: Sort item types alphabetically by description when adding a new empty record as an order to a basket
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-10-12 15:27:32 UTC
Size:
1.65 KB
patch
obsolete
>From 8c26cad196cdac33ea1df879d833b39e65e2c0a7 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Tue, 26 Sep 2023 22:40:01 +0000 >Subject: [PATCH] Bug 34908: Sort item types alphabetically by description when > adding a new empty record as an order to a basket > >To test: > >1. Go to Koha administration -> Item types. Add a new item type "B" with the description "Test" so it will be obvious if it is sorted by the code "B" instead of the description "Test". >2. Go to Acquisitions. Add to a basket from a new empty record >3. In the Catalog details section, note the Item type dropdown. Confirm your "Test" item type, is showing near the top of the list, indicating it has been sorted based on the code "B" >4. Apply patch and restart services. Refresh the page. >5. Open the Item type dropdown again and confirm your "Test" item type is showing in the expected alphabetical order. > >NC amended patch - tidied > >Sponsored-by: South Taranaki District Council >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > acqui/neworderempty.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl >index 2557a4c51b..c0bda72619 100755 >--- a/acqui/neworderempty.pl >+++ b/acqui/neworderempty.pl >@@ -361,7 +361,7 @@ if ($basketobj->effective_create_items eq 'ordering' && !$ordernumber) { > ); > } > >-my @itemtypes = Koha::ItemTypes->search->as_list; >+my @itemtypes = Koha::ItemTypes->search( {}, { order_by => { -asc => "description" } } )->as_list; > > if ( defined $from_subscriptionid ) { > # Get the last received order for this subscription >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34908
:
156248
|
156249
| 156982