From 74ed05b14375742cea60219edc819b1389da639b Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS Date: Wed, 27 Feb 2013 15:37:39 +0100 Subject: [PATCH 2/2] Bug 9720 : uninitialized value warnings in circulation (followup 1) This patch corrects several uninitialized value errors. Test plan: - Edit a borrower - Enter a surname using lowercase (it will be displayed uppercase by CSS) and save => Borrower surname is uppercase - Edit an organisation (depends on borrower category) - Enter a surname using lowercase (it will be displayed uppercase by CSS) and save => Borrower surname is uppercase - Go to a borrower page who has today issues - Click on More/Export today's checked in barcodes => You get a file to dowload --- members/memberentry.pl | 4 ++-- members/readingrec.pl | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/members/memberentry.pl b/members/memberentry.pl index f6d3e5e..1cba97f 100755 --- a/members/memberentry.pl +++ b/members/memberentry.pl @@ -667,8 +667,8 @@ if ( $op eq 'duplicate' ) { $data{'dateexpiry'} = GetExpiryDate( $data{'categorycode'}, $data{'dateenrolled'} ); } if (C4::Context->preference('uppercasesurnames')) { - $data{'surname'} =uc($data{'surname'} ); - $data{'contactname'}=uc($data{'contactname'}); + $data{'surname'} &&= uc( $data{'surname'} ); + $data{'contactname'} &&= uc( $data{'contactname'} ); } $data{debarred} = C4::Overdues::CheckBorrowerDebarred($borrowernumber); diff --git a/members/readingrec.pl b/members/readingrec.pl index d1cf5cf..ba94149 100755 --- a/members/readingrec.pl +++ b/members/readingrec.pl @@ -50,6 +50,7 @@ my ($template, $loggedinuser, $cookie)= get_template_and_user({template_name => debug => 1, }); +my $op = $input->param('op') || ''; if ($input->param('cardnumber')) { $cardnumber = $input->param('cardnumber'); $data = GetMember(cardnumber => $cardnumber); @@ -70,7 +71,7 @@ foreach my $issue ( @{$issues} ) { } # barcode export -if ( $input->param('op') eq 'export_barcodes' ) { +if ( $op eq 'export_barcodes' ) { my $today = C4::Dates->new(); $today = $today->output('iso'); my @barcodes = -- 1.7.10.4