From ae5e58d64936eee37b27b9462252147c8ab41f3f Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 11 Oct 2023 09:58:34 +0200
Subject: [PATCH] Bug 34204: Fix koha-shell under debian 12

In Debian 12/Bookworm:
root@kohadevbox:koha$ koha-shell kohadev
This account is currently not available.

This is because /etc/passwd has /usr/sbin/nologin as shell, which is coming from the --disabled-login param we passed to adduser in koha-create.

Looks like a bug has been fixed in adduser, because we didn't have this behavior in bullseye.

Context:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625758#72

"""
- change and document (adduser(8)) that --disabled-password will behave
  like --disabled-login and additionally set the shell to
  /usr/sbin/nologin.
"""
https://salsa.debian.org/debian/adduser/-/commit/427ade7d9116af5af7baa9d0c538e14fa86560cf

Test plan:
Confirm the above and that the change makes sense.

Signed-off-by: David Nind <david@davidnind.com>
---
 debian/scripts/koha-create | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/scripts/koha-create b/debian/scripts/koha-create
index fb404f470e..c0272a526e 100755
--- a/debian/scripts/koha-create
+++ b/debian/scripts/koha-create
@@ -772,7 +772,7 @@ then
     then
         die "Group $username already exists."
     fi
-    adduser --no-create-home --disabled-login \
+    adduser --no-create-home --disabled-password \
         --gecos "Koha instance $username" \
         --home "/var/lib/koha/$name" \
         --quiet "$username"
-- 
2.39.2