From af7f7d02a10e523cf7722d3f357bc1b1173a4b82 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Wed, 18 Oct 2023 16:25:26 +0000 Subject: [PATCH] Bug 35098: Fix display of clickable batch name in ILL table Test plan, k-t-d: 1) Install FreeForm and enable ILLmodule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Install an ILL availability plugin (e.g. pubmed): https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1 3) restart plack: koha-plack --restart kohadev 4) Create a new ILL batch, visit: /cgi-bin/koha/ill/ill-requests.pl 5) Click '+New ILL requests batch' 6) Input a name, '42' on the cardnumber and pick a library. Click 'Continue'. 7) On the identifiers textarea, insert '123' and click 'Process identifiers' 8) After the metadata has been retrieved, click the bottom 'Add items to batch' button, click 'Finish and view batch' 10) Go back to ILL requests table, visit: /cgi-bin/koha/ill/ill-requests.pl 11) On the top right of the table, click 'Columns' and enable Batch 12) Notice the batch column now shows correctly and is clickable --- koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js index 43f085db82..ef090e8102 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js +++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js @@ -218,11 +218,11 @@ $(document).ready(function() { "data": "batch.name", // batch "orderable": false, "render": function(data, type, row, meta) { - return row.batch ? + return row.ill_batch ? '' + - row.batch.name + + row.ill_batch.name + '' : ""; } -- 2.30.2