From 0f196970da9244be4706a9031e3c836230470fe9 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Fri, 20 Oct 2023 14:35:26 +0000 Subject: [PATCH] Bug 34497: Fix required text field input.value can be either null (if flatpickr date field empty) or '' (if simple text input empty), so check for !input.value instead to account for both situations. Add missing 'required' attribute to text inputs. --- koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue index 452038cd6d..b40436fd51 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue @@ -38,6 +38,7 @@ v-if="input.type == 'Text'" :id="`confirmation_input_${input.id}`" v-model="input.value" + :required="input.required" /> @@ -87,7 +88,7 @@ export default { if ( this.confirmation.inputs && this.confirmation.inputs.filter( - input => input.required && input.value == null + input => input.required && !input.value ).length ) { this.$refs.confirmationform.reportValidity() -- 2.30.2