Bugzilla – Attachment 157696 Details for
Bug 34136
Add ability to render a report using a notice template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34136: (QA follow-up) Perltidy
Bug-34136-QA-follow-up-Perltidy.patch (text/plain), 1.88 KB, created by
Katrin Fischer
on 2023-10-23 21:59:32 UTC
(
hide
)
Description:
Bug 34136: (QA follow-up) Perltidy
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-10-23 21:59:32 UTC
Size:
1.88 KB
patch
obsolete
>From 2f43062ca0a9f2d6ff4f33ed8056692fb2c4e03e Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Mon, 23 Oct 2023 21:42:01 +0000 >Subject: [PATCH] Bug 34136: (QA follow-up) Perltidy > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > reports/guided_reports.pl | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index e8c8941d46..6212fdae03 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -81,7 +81,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > my $session_id = $input->cookie('CGISESSID'); > my $session = $session_id ? get_session($session_id) : undef; > >-$template->param( templates => Koha::Notice::Templates->search({ module => 'report' }) ); >+$template->param( templates => Koha::Notice::Templates->search( { module => 'report' } ) ); > > my $filter; > if ( $input->param("filter_set") or $input->param('clear_filters') ) { >@@ -670,14 +670,15 @@ elsif ($phase eq 'Share'){ > } > elsif ($phase eq 'Run this report'){ > # execute a saved report >- my $limit = $input->param('limit') || 20; >- my $offset = 0; >- my $report_id = $input->param('reports'); >- my @sql_params = $input->multi_param('sql_params'); >- my @param_names = $input->multi_param('param_name'); >- my $template_id = $input->param('template'); >+ my $limit = $input->param('limit') || 20; >+ my $offset = 0; >+ my $report_id = $input->param('reports'); >+ my @sql_params = $input->multi_param('sql_params'); >+ my @param_names = $input->multi_param('param_name'); >+ my $template_id = $input->param('template'); > my $want_full_chart = $input->param('want_full_chart') || 0; > >+ > # offset algorithm > if ($input->param('page')) { > $offset = ($input->param('page') - 1) * $limit; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34136
:
152769
|
153100
|
154153
|
154227
|
157694
|
157695
| 157696