Bugzilla – Attachment 158213 Details for
Bug 35073
Serials batch edit deletes unchanged additional fields data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35073: Rename additional_fields to available_additional_fields
Bug-35073-Rename-additionalfields-to-availableaddi.patch (text/plain), 2.11 KB, created by
Victor Grousset/tuxayo
on 2023-11-01 21:12:23 UTC
(
hide
)
Description:
Bug 35073: Rename additional_fields to available_additional_fields
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2023-11-01 21:12:23 UTC
Size:
2.11 KB
patch
obsolete
>From 62b647b271373e641be345414d3aa5e72f124c1c Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 17 Oct 2023 09:18:29 +0000 >Subject: [PATCH] Bug 35073: Rename additional_fields to > available_additional_fields > >'additional_fields' is ambiguous and in other places we name this available_additional_fields instead. Do the same here. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > serials/subscription-batchedit.pl | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/serials/subscription-batchedit.pl b/serials/subscription-batchedit.pl >index 556f81e8b3..dd06fe4a22 100755 >--- a/serials/subscription-batchedit.pl >+++ b/serials/subscription-batchedit.pl >@@ -47,7 +47,7 @@ foreach my $subscriptionid (@subscriptionids) { > push @subscriptions, $subscription if $subscription; > } > >-my @additional_fields = Koha::AdditionalFields->search({tablename => 'subscription'})->as_list; >+my @available_additional_fields = Koha::AdditionalFields->search({tablename => 'subscription'})->as_list; > > my $batchedit = $cgi->param('batchedit'); > if ($batchedit) { >@@ -63,7 +63,7 @@ if ($batchedit) { > ); > > my $field_values = {}; >- foreach my $field (@additional_fields) { >+ foreach my $field (@available_additional_fields) { > my $value = $cgi->param('field_' . $field->id); > $field_values->{$field->id} = $value; > } >@@ -77,7 +77,7 @@ if ($batchedit) { > } > > my @additional_field_values; >- foreach my $field (@additional_fields) { >+ foreach my $field (@available_additional_fields) { > my $value = $field_values->{$field->id}; > if (defined $value and $value ne '') { > push @additional_field_values, { >@@ -99,7 +99,7 @@ if ($batchedit) { > $template->param( > subscriptions => \@subscriptions, > booksellers => [ Koha::Acquisition::Booksellers->search->as_list ], >- additional_fields => \@additional_fields, >+ additional_fields => \@available_additional_fields, > referrer => scalar $cgi->param('referrer'), > ); > >-- >2.42.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35073
:
157221
|
157222
|
157223
|
158038
|
158039
|
158040
| 158213 |
158214
|
158215