Bugzilla – Attachment 158259 Details for
Bug 35231
Cannot logout from OPAC and not login afterwards
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35231: Resolve crash on unexisting patron in Auth
Bug-35231-Resolve-crash-on-unexisting-patron-in-Au.patch (text/plain), 1.22 KB, created by
Marcel de Rooy
on 2023-11-02 13:50:02 UTC
(
hide
)
Description:
Bug 35231: Resolve crash on unexisting patron in Auth
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-11-02 13:50:02 UTC
Size:
1.22 KB
patch
obsolete
>From 0d0fed8018eedb20999aa8485b2a6d197aa5f4d8 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 2 Nov 2023 13:16:52 +0000 >Subject: [PATCH] Bug 35231: Resolve crash on unexisting patron in Auth >Content-Type: text/plain; charset=utf-8 > >Test plan: >Enable login in tracking triggers. Check lastseen. (Flush >the cache if needed.) >Without this patch. Logout from OPAC. Crash. >Try to login. Crash. >With this patch. Resolved. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Auth.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index a73d0c92b6..90c028b270 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -1318,8 +1318,8 @@ sub checkauth { > )); > } > >- my $patron = Koha::Patrons->find({ userid => $userid }); >- $patron->update_lastseen('login'); >+ my $patron = $userid ? Koha::Patrons->find({ userid => $userid }) : undef; >+ $patron->update_lastseen('login') if $patron; > > # In case, that this request was a login attempt, we want to prevent that users can repost the opac login > # request. We therefore redirect the user to the requested page again without the login parameters. >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35231
:
158253
|
158259
|
158260
|
158261
|
158272