Bugzilla – Attachment 158442 Details for
Bug 33928
Improve translation of title tags: Various
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33928: Improve translation of title tags: Various
Bug-33928-Improve-translation-of-title-tags-Variou.patch (text/plain), 5.91 KB, created by
Katrin Fischer
on 2023-11-05 10:28:26 UTC
(
hide
)
Description:
Bug 33928: Improve translation of title tags: Various
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-11-05 10:28:26 UTC
Size:
5.91 KB
patch
obsolete
>From 99cd6f2dd5d765f9887670819d1ba8da3be16752 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 6 Oct 2023 17:16:20 +0000 >Subject: [PATCH] Bug 33928: Improve translation of title tags: Various > >This patch updates various templates so that title tags can be more >easily translated. Some templates have been updated for consistency as >well: Harmonizing page title, breaddrumb navigation, and page headers. > >To test, apply the patch and confirm that the following pages have the >correct title tags: > >- Staff interface -> Log in > - Staff interface home page > - Error page (e.g. for a missing page 404 error) > - About page > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/about.tt | 6 ++- > .../intranet-tmpl/prog/en/modules/auth.tt | 41 ++++++++++++++----- > .../prog/en/modules/errors/errorpage.tt | 10 +++-- > .../prog/en/modules/intranet-main.tt | 5 ++- > 4 files changed, 46 insertions(+), 16 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index da6183cbbd..df6cca50a4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -3,9 +3,13 @@ > [% USE Koha %] > [% USE Asset %] > [% USE KohaDates %] >+[% PROCESS 'i18n.inc' %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >-<title>About Koha › Koha</title> >+<title>[% FILTER collapse %] >+ [% t("About Koha") | html %] › >+ [% t("Koha") | html %] >+[% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] > </head> > <body id="about_about" class="about"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt >index e87cb438c4..e7b6e0ac5d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt >@@ -6,19 +6,38 @@ > [% USE Categories %] > [% USE Registers %] > [% USE AuthClient %] >+[% PROCESS 'i18n.inc' %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >-<title> >- [% IF TwoFA_prompt %]Two-factor authentication[% END %] >- [% IF TwoFA_setup %]Two-factor authentication setup[% END %] >- [% IF ( loginprompt ) %]Log in to Koha[% END %] >- [% IF too_many_login_attempts %]This account has been locked. >- [% ELSIF invalid_username_or_password %]Invalid username or password[% END %] >- [% IF ( different_ip ) %]IP address change[% END %] >- [% IF ( timed_out ) %]Session timed out[% END %] >- [% IF ( nopermission ) %]Access denied[% END %] >- [% IF ( auth_error ) %]Error authenticating with external provider[% END %] › Koha >-</title> >+<title>[% FILTER collapse %] >+ [% IF TwoFA_prompt %] >+ [% t("Two-factor authentication") | html %] › >+ [% END %] >+ [% IF TwoFA_setup %] >+ [% t("Two-factor authentication setup") | html %] › >+ [% END %] >+ [% IF too_many_login_attempts %] >+ [% t("This account has been locked.") | html %] › >+ [% ELSIF invalid_username_or_password %] >+ [% t("Invalid username or password") | html %] › >+ [% END %] >+ [% IF ( different_ip ) %] >+ [% t("IP address change") | html %] › >+ [% END %] >+ [% IF ( timed_out ) %] >+ [% t("Session timed out") | html %] › >+ [% END %] >+ [% IF ( nopermission ) %] >+ [% t("Access denied") | html %] › >+ [% END %] >+ [% IF ( auth_error ) %] >+ [% t("Error authenticating with external provider") | html %] › >+ [% END %] >+ [% IF ( loginprompt ) %] >+ [% t("Log in to Koha") | html %] › >+ [% END %] >+ [% t("Koha") | html %] >+[% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] > [% PROCESS 'auth-two-factor.inc' %] > </head> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt >index 0d5e45b90e..2d84003291 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt >@@ -1,6 +1,10 @@ > [% USE raw %] >+[% PROCESS 'i18n.inc' %] > [% INCLUDE 'doc-head-open.inc' %] >-<title>Error [% errno | html %] › Koha</title> >+<title>[% FILTER collapse %] >+ [% tx("Error {error_number}", {error_number = errno }) | html %] › >+ [% t("Koha") | html %] >+[% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] > </head> > <body id="err_[% errno | html %]" class="err"> >@@ -13,7 +17,7 @@ > [% WRAPPER breadcrumbs %] > [% WRAPPER breadcrumb_item %] > <a href="#" aria-current="page"> >- Error [% errno | html %] >+ [% tx("Error {error_number}", {error_number = errno }) | html %] > </a> > [% END %] > [% END #/ WRAPPER breadcrumbs %] >@@ -24,7 +28,7 @@ > <div class="col-md-8 col-md-offset-2"> > > <h1>An error has occurred!</h1> >- <h2><em>Error [% errno | html %]</em></h2> >+ <h2><em>[% tx("Error {error_number}", {error_number = errno }) | html %]</em></h2> > <h3>This message may have been caused by any of the following reasons:</h3> > <ul style="padding-bottom: 0.5em;"> > <li>You made use of an external link to an item that is no longer available</li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >index 85feef5609..c066fe3ace 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >@@ -3,9 +3,12 @@ > [% USE Koha %] > [% USE Branches %] > [% USE KohaDates %] >+[% PROCESS 'i18n.inc' %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >-<title>Koha staff interface</title> >+<title>[% FILTER collapse %] >+ [% t("Koha staff interface") | html %] >+[% END %]</title> > [% Asset.css("css/mainpage.css") | $raw %] > [% INCLUDE 'doc-head-close.inc' %] > </head> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33928
:
156635
|
158286
| 158442