From a9c4fcddbad9c11465162a68c38383aaad42a8c2 Mon Sep 17 00:00:00 2001 From: Owen Leonard <oleonard@myacpl.org> Date: Tue, 7 Nov 2023 17:07:17 +0000 Subject: [PATCH] Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form This patch makes a minor correction to the JavaScript controlling the behavior of the "clear" link which appears on the patron entry form next to patron attribute <select>s or <textarea>s which are editable in the OPAC. To test, apply the patch and create patron attributes which have both "Display in OPAC" and "Editable in OPAC" checked. - Create one which is tied to an authorized value, and one which isn't. - Log in to the OPAC and click the "Personal details" tab. - In the entry form, find the patron attribute fields under the Additional information" heading.. - Select a value in the dropdown, and enter text in the textarea. - Confirm that clicking the corresponding "Clear" link for each works as expected. --- .../opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index fd9587ce3d..02c81192a7 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -1199,12 +1199,11 @@ [% END %] [% END %] - $(".patron-attributes").on( 'click', '.clear-attribute', function() { + $(".patron-attributes").on( 'click', '.clear-attribute', function(e) { + e.preventDefault(); $(this).parent() - .find('textarea').attr('value', '').end() - .find('select').attr('value', '').end(); - - return false; + .find('textarea').val("").end() + .find('select').val("").end(); } ); $(".patron-attributes").on( 'click', '.clone-attribute', function() { -- 2.30.2