From 1daafc6929cf0924c7f65adab39d9550b1dc2990 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Date: Thu, 9 Nov 2023 10:35:06 +0000 Subject: [PATCH] Bug 35194: Remove obsoleted sortable function Removes two occurrences and a commented one. Test plan: [1] Go to cataloguing editor. Open dev console. Clone 500. [2] Go to Admin/Did you mean. Try to toggle options. With this patch it works. Without this patch, JS errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt | 1 - koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 2 -- koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js | 1 - 3 files changed, 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt index 3e3b66ebde..41b0ecccb0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt @@ -93,7 +93,6 @@ [% Asset.js("js/admin-menu.js") | $raw %] <script> $(document).ready(function() { - $( ".pluginlist" ).sortable(); $( ".plugin" ).addClass( "ui-widget ui-widget-content ui-helper-clearfix ui-corner-all" ) .find( ".pluginname" ) .addClass( "ui-widget-header ui-corner-all" ) diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js index 8808df2c71..f257b19666 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js +++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js @@ -324,8 +324,6 @@ function CloneField(index, hideMarc, advancedMARCEditor) { // insert this line on the page original.parentNode.insertBefore(clone,original.nextSibling); - $("ul.sortable_subfield", clone).sortable(); - Select2Utils.initSelect2($(original).find('select')); Select2Utils.initSelect2($(clone).find('select')); } diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js b/koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js index 710652f87c..f6c12f8138 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js +++ b/koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js @@ -59,7 +59,6 @@ $(document).ready(function() { $('#ajax_saving_icon').hide(); $('#ajax_failed_icon').show(); $('#ajax_failed_msg').show(); - // $('#sortable_stages').sortable('cancel'); }) .always(function() { sortable_stages.option("disabled", false ); -- 2.30.2