Bugzilla – Attachment 158767 Details for
Bug 35273
When editing items on receive, aqorders_items is not updated correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35273: Fix item selection when receiving
Bug-35273-Fix-item-selection-when-receiving.patch (text/plain), 1.88 KB, created by
Katrin Fischer
on 2023-11-09 21:15:39 UTC
(
hide
)
Description:
Bug 35273: Fix item selection when receiving
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-11-09 21:15:39 UTC
Size:
1.88 KB
patch
obsolete
>From a042e9c800ab83fc72aa35257270c7bc1697bbcd Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 7 Nov 2023 11:23:34 +0100 >Subject: [PATCH] Bug 35273: Fix item selection when receiving > >For partial receives with items created on order, the >aqorders_items table was not correctly updated when only >some of the ordered items were received. > >To test: >1) Create a basket with creating items on order >2) Create an order line with 3 items >3) Close basked >4) Receive shipment and create invoice >5) Receive your created order line >6) Edit first item displayed, add barcode >7) Check checkbox and receive >8) Verify the order line has been split 2:1 >9) Receive again - notice all 3 items are showing. > We should only see the remaining 2 >10) Undo receive >11) Apply patch >12) Repeat steps 5)-9) >13) Verify that in step 9) only the remaining 2 items display now. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >index a598ee2ec6..c20f14bf99 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >@@ -511,6 +511,11 @@ > item._checked = $(tr).find('input[type="checkbox"]').prop('checked'); > tr.html(''); > _build_item(item, tr); >+ >+ var row = $("#order_edit").data('row'); >+ row.items.forEach((it, i) => { if (it.item_id == itemnumber) { >+ row.items[i] = item; >+ }}); > } > }); > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35273
:
158587
|
158767
|
158796