From f7cf9eb509fe7ceb127720033fa5be81f593a712 Mon Sep 17 00:00:00 2001
From: Aleisha Amohia <aleishaamohia@hotmail.com>
Date: Mon, 4 Oct 2021 17:20:28 +1300
Subject: [PATCH] Bug 31391: RecallsInterface system preference

Signed-off-by: David <david@davidnind.com>
Signed-off-by: David Nind <david@davidnind.com>
---
 .../bug_31391_-_add_RecallsInterface_syspref.pl      | 12 ++++++++++++
 installer/data/mysql/mandatory/sysprefs.sql          |  1 +
 .../en/modules/admin/preferences/circulation.pref    | 10 ++++++++++
 3 files changed, 23 insertions(+)
 create mode 100644 installer/data/mysql/atomicupdate/bug_31391_-_add_RecallsInterface_syspref.pl

diff --git a/installer/data/mysql/atomicupdate/bug_31391_-_add_RecallsInterface_syspref.pl b/installer/data/mysql/atomicupdate/bug_31391_-_add_RecallsInterface_syspref.pl
new file mode 100644
index 0000000000..48ca6d92bc
--- /dev/null
+++ b/installer/data/mysql/atomicupdate/bug_31391_-_add_RecallsInterface_syspref.pl
@@ -0,0 +1,12 @@
+use Modern::Perl;
+
+return {
+    bug_number => "31391",
+    description => "Add new system preference RecallsInterface",
+    up => sub {
+        my ($args) = @_;
+        my ($dbh, $out) = @$args{qw(dbh out)};
+
+        $dbh->do(q{INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES ('RecallsInterface','opac','opac|staff|both','The interface that recalls can be placed through','Choice') });
+    },
+};
diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
index b58114d802..ca8e18d12b 100644
--- a/installer/data/mysql/mandatory/sysprefs.sql
+++ b/installer/data/mysql/mandatory/sysprefs.sql
@@ -610,6 +610,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
 ('QuoteOfTheDay','','intranet,opac','Enable or disable display of Quote of the Day on the OPAC and staff interface home page','multiple'),
 ('RandomizeHoldsQueueWeight','0',NULL,'if ON, the holds queue in circulation will be randomized, either based on all location codes, or by the location codes specified in StaticHoldsQueueWeight','YesNo'),
 ('RealTimeHoldsQueue', '0', NULL, 'Enable updating the holds queue in real time', 'YesNo'),
+('RecallsInterface','opac','opac|staff|both','The interface that recalls can be placed through','Choice'),
 ('RecallsLog','1',NULL,'If ON, log create/cancel/expire/fulfill actions on recalls','YesNo'),
 ('RecallsMaxPickUpDelay','7',NULL,'Define the maximum time a recall can be awaiting pickup','Integer'),
 ('RecordLocalUseOnReturn','0',NULL,'If ON, statistically record returns of unissued items as local use, instead of return','YesNo'),
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
index 40f2d65a81..b1a6e790cd 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ -1352,6 +1352,7 @@ Circulation:
             - days.
         -
             - pref: UseRecalls
+              type: boolean
               choices:
                   1: Use
                   0: "Don't use"
@@ -1399,3 +1400,12 @@ Circulation:
                   1: Enable
                   0: Disable
             - "the curbside pickup module."
+        -
+            - Recalls can be placed through
+            - pref: RecallsInterface
+              default: opac
+              choices:
+                  opac: the OPAC only
+                  staff: the staff interface only
+                  both: both the OPAC and the staff interface
+            - . (Requires <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=UseRecalls">UseRecalls</a>.)
-- 
2.30.2