Bugzilla – Attachment 159336 Details for
Bug 35431
TransportCostMatrix should be checked after HoldsQueuePrioritizeBranch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35431: Check TransportCostMatrix if hold not filled by HoldsQueuePrioritizeBranch
Bug-35431-Check-TransportCostMatrix-if-hold-not-fi.patch (text/plain), 1.15 KB, created by
Nick Clemens (kidclamp)
on 2023-11-29 13:37:35 UTC
(
hide
)
Description:
Bug 35431: Check TransportCostMatrix if hold not filled by HoldsQueuePrioritizeBranch
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-11-29 13:37:35 UTC
Size:
1.15 KB
patch
obsolete
>From d8095a74b4f7065dca9644dd8d393078c1032414 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 29 Nov 2023 13:12:52 +0000 >Subject: [PATCH] Bug 35431: Check TransportCostMatrix if hold not filled by > HoldsQueuePrioritizeBranch > >This patch changes an elsif to an if to ensure the matrix is checked every time > >To test: >1 - Apply unit test patch only >2 - prove -v t/db_dependent/HoldQueue.t >3 - It fails >4 - Apply this patch >5 - prove -v t/db_dependent/HoldQueue.t >6 - It passes >7 - All other tests continue to pass as well >--- > C4/HoldsQueue.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index 5e555f4f959..12ce63f7cfd 100644 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -573,7 +573,7 @@ sub MapItemsToHoldRequests { > } > $holdingbranch = $pickup_branch; > } >- elsif ($transport_cost_matrix) { >+ if ($transport_cost_matrix) { > $pull_branches = [keys %items_by_branch]; > $holdingbranch = least_cost_branch( $pickup_branch, $pull_branches, $transport_cost_matrix ); > if ( $holdingbranch ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35431
:
159335
| 159336