Bugzilla – Attachment 159443 Details for
Bug 35438
Importing records can create too large transactions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35438: Remove skip_intermediate_commit parameter
Bug-35438-Remove-skipintermediatecommit-parameter.patch (text/plain), 1.94 KB, created by
Kyle M Hall
on 2023-12-01 11:53:47 UTC
(
hide
)
Description:
Bug 35438: Remove skip_intermediate_commit parameter
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2023-12-01 11:53:47 UTC
Size:
1.94 KB
patch
obsolete
>From f2e4363d67f1877157d8140c8a58bde13df3be19 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 1 Dec 2023 06:53:21 -0500 >Subject: [PATCH] Bug 35438: Remove skip_intermediate_commit parameter > >It no longer does anything. >--- > C4/ImportBatch.pm | 4 ---- > Koha/BackgroundJob/MARCImportCommitBatch.pm | 1 - > 2 files changed, 5 deletions(-) > >diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm >index 2fb22c64fd7..0cfd132edf0 100644 >--- a/C4/ImportBatch.pm >+++ b/C4/ImportBatch.pm >@@ -520,10 +520,7 @@ sub BatchFindDuplicates { > overlay_framework => $overlay_framework, > progress_interval => $progress_interval, > progress_callback => $progress_callback, >- skip_intermediate_commit => $skip_intermediate_commit > }); >- >- Parameter skip_intermediate_commit does what is says. > =cut > > sub BatchCommitRecords { >@@ -531,7 +528,6 @@ sub BatchCommitRecords { > my $batch_id = $params->{batch_id}; > my $framework = $params->{framework}; > my $overlay_framework = $params->{overlay_framework}; >- my $skip_intermediate_commit = $params->{skip_intermediate_commit}; > my $progress_interval = $params->{progress_interval} // 0; > my $progress_callback = $params->{progress_callback}; > $progress_interval = 0 unless $progress_interval && $progress_interval =~ /^\d+$/; >diff --git a/Koha/BackgroundJob/MARCImportCommitBatch.pm b/Koha/BackgroundJob/MARCImportCommitBatch.pm >index 22398aef29d..d2d45b6070e 100644 >--- a/Koha/BackgroundJob/MARCImportCommitBatch.pm >+++ b/Koha/BackgroundJob/MARCImportCommitBatch.pm >@@ -78,7 +78,6 @@ sub process { > progress_interval => 50, > progress_callback => > sub { my $job_progress = shift; $self->progress( $job_progress )->store }, >- skip_intermediate_commit => 1, > }); > my $count = $num_added + $num_updated; > if( $count ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35438
:
159413
|
159415
|
159442
|
159443
|
160917
|
160918