From f586e0203bd58d1c72a3b4fe4201742769bc7102 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Tue, 17 Oct 2023 12:49:55 +0100 Subject: [PATCH] Bug 34077: Update output to match POD This patch adds a check on !$confirm such that we enable verbose output should the confirm flag not be passed. This adheres with what the documentation already states. --- misc/cronjobs/writeoff_debts.pl | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/misc/cronjobs/writeoff_debts.pl b/misc/cronjobs/writeoff_debts.pl index dad36ffaf9e..085f6dbd2dc 100755 --- a/misc/cronjobs/writeoff_debts.pl +++ b/misc/cronjobs/writeoff_debts.pl @@ -24,7 +24,7 @@ GetOptions( ); @type = split( /,/, join( ',', @type ) ); -pod2usage(1) if ( $help || !$confirm && !$verbose || !$file && !@type && !$before && !$after ); +pod2usage(1) if ( $help || !$file && !@type && !$before && !$after ); my $where = { 'amountoutstanding' => { '>' => 0 } }; my $attr = {}; @@ -66,10 +66,15 @@ if (@category_code) { } my $lines = Koha::Account::Lines->search( $where, $attr ); + +$verbose //= !$confirm; if ( $verbose ) { - print "Attempting to write off " . $lines->count . " debts"; + print "Attempting to write off " . $lines->count . " debts" if $confirm; + print "With --confirm we would write off " . $lines->count . " debts" if !$confirm; print " of type " . join(',',@type) if @type; + print " for patron categories " . join(', ', @category_code) if @category_code; print " added before " . $before if $before; + print " added after " . $after if $after; print " from the passed list" if $file; print "\n"; } -- 2.43.0