From 1fdf21677ab0fb2de07b693aab3d352a0dd27695 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Sun, 10 Dec 2023 14:00:04 +0000
Subject: [PATCH] Bug 35526: Fix terminology and spelling for ERM data
 providers

This makes several changes on the form for adding a data provider
and on the data provider details page:

* Enable ERMModule system preference
* Go to the ERM module, add a new data provider
  * Look at the labels on the form
  * Save and check the labels on the summary tab
* Apply patch, run: yarn build
  * Verify fixes
    ...Id => ID
    ...sushi => SUSHI
    ...counter => COUNTER
    ...Report Release => Report release
    ...

Signed-off-by: David Nind <david@davidnind.com>
---
 .../ERM/UsageStatisticsDataProviderDetails.vue   | 16 ++++++++--------
 .../ERM/UsageStatisticsDataProvidersFormAdd.vue  | 12 ++++++------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProviderDetails.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProviderDetails.vue
index 3b9b4eee47..9190f5834a 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProviderDetails.vue
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProviderDetails.vue
@@ -21,7 +21,7 @@
                 </span>
             </li>
             <li>
-                <label>{{ $__("Service Type") }}:</label>
+                <label>{{ $__("Service type") }}:</label>
                 <span id="usage_data_provider_service_type">
                     {{ usage_data_provider.service_type }}
                 </span>
@@ -34,7 +34,7 @@
             </li>
         </ol>
     </fieldset>
-    <legend>{{ $__("Sushi credentials") }}</legend>
+    <legend>{{ $__("SUSHI credentials") }}</legend>
     <fieldset class="rows">
         <ol>
             <li>
@@ -44,37 +44,37 @@
                 </span>
             </li>
             <li>
-                <label>{{ $__("Report Release") }}:</label>
+                <label>{{ $__("Report release") }}:</label>
                 <span id="usage_data_provider_report_release">
                     {{ usage_data_provider.report_release }}
                 </span>
             </li>
             <li>
-                <label>{{ $__("Customer Id") }}:</label>
+                <label>{{ $__("Customer ID") }}:</label>
                 <span id="usage_data_provider_customer_id">
                     {{ usage_data_provider.customer_id }}
                 </span>
             </li>
             <li>
-                <label>{{ $__("Requestor Id") }}:</label>
+                <label>{{ $__("Requestor ID") }}:</label>
                 <span id="usage_data_provider_requestor_id">
                     {{ usage_data_provider.requestor_id }}
                 </span>
             </li>
             <li>
-                <label>{{ $__("API Key") }}:</label>
+                <label>{{ $__("API key") }}:</label>
                 <span id="usage_data_provider_api_key">
                     {{ usage_data_provider.api_key }}
                 </span>
             </li>
             <li>
-                <label>{{ $__("Requestor Name") }}:</label>
+                <label>{{ $__("Requestor name") }}:</label>
                 <span id="usage_data_provider_requestor_name">
                     {{ usage_data_provider.requestor_name }}
                 </span>
             </li>
             <li>
-                <label>{{ $__("Requestor Email") }}:</label>
+                <label>{{ $__("Requestor email") }}:</label>
                 <span id="usage_data_provider_requestor_email">
                     {{ usage_data_provider.requestor_email }}
                 </span>
diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue
index 6638765fe0..3c4437a921 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue
@@ -218,7 +218,7 @@
                                         : ''
                                 "
                                 for="usage_data_provider_customer_id"
-                                >{{ $__("Customer Id") }}:
+                                >{{ $__("Customer ID") }}:
                             </label>
                             <input
                                 id="usage_data_provider_customer_id"
@@ -241,7 +241,7 @@
                                         : ''
                                 "
                                 for="usage_data_provider_requestor_id"
-                                >{{ $__("Requestor Id") }}:
+                                >{{ $__("Requestor ID") }}:
                             </label>
                             <input
                                 id="usage_data_provider_requestor_id"
@@ -308,7 +308,7 @@
                         <h3>{{ $__("Credentials information") }}</h3>
                         <li>
                             <label for="customer_id_info"
-                                >{{ $__("Customer id info") }}:
+                                >{{ $__("Customer ID info") }}:
                             </label>
                             <span id="customer_id_info">{{
                                 sushi_service.customer_id_info
@@ -318,7 +318,7 @@
                         </li>
                         <li>
                             <label for="requestor_id_info"
-                                >{{ $__("Requestor id info") }}:
+                                >{{ $__("Requestor ID info") }}:
                             </label>
                             <span id="requestor_id_info">{{
                                 sushi_service.requestor_id_info
@@ -339,7 +339,7 @@
                         <span
                             >{{ $__("Please refer to the ") }}
                             <a href="https://registry.projectcounter.org/">{{
-                                $__("counter registry")
+                                $__("COUNTER registry")
                             }}</a>
                             {{ $__("for more information.") }}</span
                         >
@@ -497,7 +497,7 @@ export default {
             if (this.valid_report_types.length === 0) {
                 setWarning(
                     this.$__(
-                        "This provider does not currently support any counter 5 reports via SUSHI."
+                        "This provider does not currently support any COUNTER 5 reports via SUSHI."
                     )
                 )
             }
-- 
2.30.2