From dd38bafa162c9df3cbbec868ad22cc4c0b233243 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Thu, 14 Dec 2023 14:16:01 +0000 Subject: [PATCH] Bug 35581: Illbackend.pm -> ILL/Backend.pm --- Koha/{Illbackend.pm => ILL/Backend.pm} | 8 ++++---- Koha/REST/V1/{Illbackends.pm => ILL/Backends.pm} | 12 ++++++------ api/v1/swagger/paths/ill_backends.yaml | 8 ++++---- t/db_dependent/Koha/{Illbackend.t => ILL/Backend.t} | 6 +++--- 4 files changed, 17 insertions(+), 17 deletions(-) rename Koha/{Illbackend.pm => ILL/Backend.pm} (96%) rename Koha/REST/V1/{Illbackends.pm => ILL/Backends.pm} (89%) rename t/db_dependent/Koha/{Illbackend.t => ILL/Backend.t} (97%) diff --git a/Koha/Illbackend.pm b/Koha/ILL/Backend.pm similarity index 96% rename from Koha/Illbackend.pm rename to Koha/ILL/Backend.pm index ab31d05495..de6746af99 100644 --- a/Koha/Illbackend.pm +++ b/Koha/ILL/Backend.pm @@ -1,4 +1,4 @@ -package Koha::Illbackend; +package Koha::ILL::Backend; # Copyright PTFS Europe 2023 # @@ -23,13 +23,13 @@ use base qw(Koha::Object); =head1 NAME -Koha::Illbackend - Koha Illbackend Object class +Koha::ILL::Backend - Koha Illbackend Object class =head2 Class methods =head3 new -New illbackend +New ILL Backend =cut @@ -127,7 +127,7 @@ sub embed { =head3 _type - my $type = Koha::Illbackend->_type; + my $type = Koha::ILL::Backend->_type; Return this object's type diff --git a/Koha/REST/V1/Illbackends.pm b/Koha/REST/V1/ILL/Backends.pm similarity index 89% rename from Koha/REST/V1/Illbackends.pm rename to Koha/REST/V1/ILL/Backends.pm index 8b70d9368e..302e0c8edb 100644 --- a/Koha/REST/V1/Illbackends.pm +++ b/Koha/REST/V1/ILL/Backends.pm @@ -1,4 +1,4 @@ -package Koha::REST::V1::Illbackends; +package Koha::REST::V1::ILL::Backends; # This file is part of Koha. # @@ -21,11 +21,11 @@ use Mojo::Base 'Mojolicious::Controller'; use Koha::Illrequest::Config; use Koha::Illrequests; -use Koha::Illbackend; +use Koha::ILL::Backend; =head1 NAME -Koha::REST::V1::Illbackends +Koha::REST::V1::ILL::Backends =head2 Operations @@ -66,18 +66,18 @@ sub get { return try { - #FIXME: Should we move load_backend into Koha::Illbackend... + #FIXME: Should we move load_backend into Koha::ILL::Backend... # or maybe make Koha::Ill::Backend a base class for all # backends? my $backend = Koha::Illrequest->new->load_backend($backend_id); - my $backend_module = Koha::Illbackend->new; + my $backend_module = Koha::ILL::Backend->new; my $embed = $backend_module->embed( $backend_id, $c->req->headers->header('x-koha-embed') ); - #TODO: We need a to_api method in Koha::Illbackend + #TODO: We need a to_api method in Koha::ILL::Backend my $return = { ill_backend_id => $backend_id, capabilities => $backend->capabilities, diff --git a/api/v1/swagger/paths/ill_backends.yaml b/api/v1/swagger/paths/ill_backends.yaml index 874481a5ec..cc5f2247a8 100644 --- a/api/v1/swagger/paths/ill_backends.yaml +++ b/api/v1/swagger/paths/ill_backends.yaml @@ -1,8 +1,8 @@ --- /ill/backends: get: - x-mojo-to: Illbackends#list - operationId: listIllbackends + x-mojo-to: ILL::Backends#list + operationId: listIllBackends tags: - ill_backends summary: List ILL backends @@ -42,8 +42,8 @@ ill: "1" "/ill/backends/{ill_backend_id}": get: - x-mojo-to: Illbackends#get - operationId: getIllbackends + x-mojo-to: ILL::Backends#get + operationId: getIllBackends tags: - ill_backends summary: Get ILL backend diff --git a/t/db_dependent/Koha/Illbackend.t b/t/db_dependent/Koha/ILL/Backend.t similarity index 97% rename from t/db_dependent/Koha/Illbackend.t rename to t/db_dependent/Koha/ILL/Backend.t index 79d9477b3a..aef6b0c310 100755 --- a/t/db_dependent/Koha/Illbackend.t +++ b/t/db_dependent/Koha/ILL/Backend.t @@ -21,7 +21,7 @@ use Modern::Perl; use Test::More tests => 1; -use Koha::Illbackend; +use Koha::ILL::Backend; use t::lib::TestBuilder; use t::lib::Mocks; @@ -36,7 +36,7 @@ subtest 'existing_statuses() tests' => sub { $schema->storage->txn_begin; Koha::Illrequests->search->delete; - # Mock ILLBackend (as object) + # Mock external ILLBackend (as object) my $backend = Test::MockObject->new; $backend->set_isa('Koha::Illbackends::Mock'); $backend->set_always( 'name', 'Mock' ); @@ -133,7 +133,7 @@ subtest 'existing_statuses() tests' => sub { } ); - my $backend_module = Koha::Illbackend->new; + my $backend_module = Koha::ILL::Backend->new; my $existing_statuses = $backend_module->existing_statuses('Mock'); -- 2.30.2