From ca9ea8cbced3d70c5d6201faf2f8749c371d1415 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 13 Dec 2023 11:10:24 +0100
Subject: [PATCH] Bug 35558: Do not retrieve the local image if none exists

On the search results we are fetching the thumbnails of the local cover
images using catalogue/image.pl
Which means 1 GET per results on the page.

This patch suggests to have this information beforehand in order to
reduce the number of hits and network traffic?

However the page load will be slightly slower ofc.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
---
 catalogue/search.pl                                          | 4 ++++
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/catalogue/search.pl b/catalogue/search.pl
index e3da85daee..ab9abbfed8 100755
--- a/catalogue/search.pl
+++ b/catalogue/search.pl
@@ -665,6 +665,10 @@ for (my $i=0;$i<@servers;$i++) {
                 if ( grep {$_ eq $line->{'biblionumber'}} @cart_list) {
                     $line->{'incart'} = 1;
                 }
+
+                if ( C4::Context->preference('LocalCoverImages') ) {
+                    $line->{has_local_cover_image} = $line->{biblio_object}->cover_images->count;
+                }
             }
             my( $page_numbers, $hits_to_paginate, $pages, $current_page_number, $previous_page_offset, $next_page_offset, $last_page_offset ) =
                 Koha::SearchEngine::Search->pagination_bar(
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
index 16938a6f6c..6a5b62965b 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
@@ -484,7 +484,7 @@
                                             [% IF ( CoverImagePlugins || AmazonCoverImages  || LocalCoverImages || IntranetCoce || ( SyndeticsCovers ) || (Koha.Preference('CustomCoverImages') && Koha.Preference('CustomCoverImagesURL')) ) %]
     <td class="bookcoverimg">
         <div id="cover-slides-[% SEARCH_RESULT.biblionumber | html %]" class="cover-slides" data-biblionumber="[% SEARCH_RESULT.biblionumber | html %]" data-isbn="[% To.json(SEARCH_RESULT.normalized_isbn) | $raw %]" data-processedbiblio="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber | $raw %]">
-            [% IF ( LocalCoverImages ) %]
+            [% IF ( LocalCoverImages && SEARCH_RESULT.has_local_cover_image ) %]
                 <div id="local-coverimg-[% SEARCH_RESULT.biblionumber | html %]" class="cover-image local-coverimg">
                     <a href="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber %]">
                         <img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&amp;biblionumber=[% SEARCH_RESULT.biblionumber | uri %]" alt="Local cover image" />
-- 
2.30.2