From 324b8a3f89fb9f3dd03301ab563bb80c1433f76e Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 19 Dec 2023 13:41:08 -0500 Subject: [PATCH] Bug 28530: (QA follow-up): Fix qa issues --- Koha/Library/FloatLimits.pm | 3 ++- admin/float_limits.pl | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Koha/Library/FloatLimits.pm b/Koha/Library/FloatLimits.pm index ddeeb47afbe..a6eb4c43bac 100644 --- a/Koha/Library/FloatLimits.pm +++ b/Koha/Library/FloatLimits.pm @@ -50,7 +50,8 @@ sub lowest_ratio_library { LEFT JOIN items ON ( items.itype = library_float_limits.itemtype AND items.holdingbranch = library_float_limits.branchcode ) LEFT JOIN biblioitems ON ( items.biblioitemnumber = biblioitems.biblioitemnumber ) WHERE library_float_limits.itemtype = ? - AND $field = ? + AND ( $field = ? OR $field IS NULL ) + AND library_float_limits.limit != 0 GROUP BY branchcode ORDER BY COUNT(items.holdingbranch)/library_float_limits.limit }; diff --git a/admin/float_limits.pl b/admin/float_limits.pl index c07b24227d6..897e531d059 100755 --- a/admin/float_limits.pl +++ b/admin/float_limits.pl @@ -65,7 +65,7 @@ if ( $op eq 'set_float_limits' ) { limit => $limit } )->store() - if $limit; # update or insert + if $limit ne q{}; # update or insert } } $template->param( float_limits_updated => 1 ); diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc index c7caffc0143..71ecf63c6ba 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc @@ -41,6 +41,7 @@ [% IF ( CAN_user_parameters_manage_transfers ) %]
  • Library transfer limits
  • Transport cost matrix
  • +
  • Library float limits
  • [% END %] [% IF ( CAN_user_parameters_manage_item_circ_alerts ) %]
  • Item circulation alerts
  • -- 2.30.2