Bugzilla – Attachment 160556 Details for
Bug 35293
Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35293: Unit test
Bug-35293-Unit-test.patch (text/plain), 2.04 KB, created by
Nick Clemens (kidclamp)
on 2024-01-04 19:25:37 UTC
(
hide
)
Description:
Bug 35293: Unit test
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-01-04 19:25:37 UTC
Size:
2.04 KB
patch
obsolete
>From a989a151c2b333419b47b3463faa7fc6cd842200 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 3 Jan 2024 19:46:15 +0000 >Subject: [PATCH] Bug 35293: Unit test > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/Circulation/issue.t | 28 ++++++++++++++++++++++++---- > 1 file changed, 24 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Circulation/issue.t b/t/db_dependent/Circulation/issue.t >index c9cd7f26ffa..86720d8edfb 100755 >--- a/t/db_dependent/Circulation/issue.t >+++ b/t/db_dependent/Circulation/issue.t >@@ -17,7 +17,7 @@ > > use Modern::Perl; > >-use Test::More tests => 66; >+use Test::More tests => 67; > use DateTime::Duration; > > use t::lib::Mocks; >@@ -462,11 +462,31 @@ AddReturn( 'barcode_3', $branchcode_1 ); > $item = Koha::Items->find( $itemnumber ); > ok( $item->notforloan eq 0, q{UpdateNotForLoanStatusOnCheckin _ALL_ rules are applied if there are no specific item type rule matching the returned item} ); > >-t::lib::Mocks::mock_preference( 'UpdateNotForLoanStatusOnCheckin', '1: ONLYMESSAGE' ); >+t::lib::Mocks::mock_preference( >+ 'UpdateNotForLoanStatusOnCheckin', q{_ALL_: >+ 1: ONLYMESSAGE >+} >+); > $item->notforloan(1)->store; > AddReturn( 'barcode_3', $branchcode_1 ); >-$item = Koha::Items->find( $itemnumber ); >-ok( $item->notforloan eq 1, q{UpdateNotForLoanStatusOnCheckin does not update notforloan value from 1 with setting "1: ONLYMESSAGE"} ); >+$item->discard_changes; >+is( >+ $item->notforloan, 1, >+ q{UpdateNotForLoanStatusOnCheckin does not update notforloan value from 1 for _ALL_ with setting "1: ONLYMESSAGE"} >+); >+ >+ >+t::lib::Mocks::mock_preference( >+ 'UpdateNotForLoanStatusOnCheckin', "$itemtype:\n >+ 1: ONLYMESSAGE >+" >+); >+AddReturn( 'barcode_3', $branchcode_1 ); >+$item->discard_changes; >+is( >+ $item->notforloan, 1, >+ q{UpdateNotForLoanStatusOnCheckin does not update notforloan value for specific itemtype from 1 with setting "1: ONLYMESSAGE"} >+); > > my $itemnumber2 = Koha::Item->new( > { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35293
:
158850
|
158851
|
160360
|
160361
|
160362
|
160553
|
160554
|
160555
| 160556