Attachment 160630 Details for Bug 35725 – Bug 35725: Keep cardnumber and library data when changing request type

[patch] Bug 35725: Keep cardnumber and library data when changing request type

Bug-35725-Keep-cardnumber-and-library-data-when-ch.patch (text/plain), 2.04 KB, created by Pedro Amorim on 2024-01-08 14:45:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-01-08 14:45:21 UTC

Size: 2.04 KB

patch

obsolete

>From 9ececaaea9437690f21f12fd7566709a2e80e71c Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Mon, 8 Jan 2024 14:43:43 +0000
>Subject: [PATCH] Bug 35725: Keep cardnumber and library data when changing
> request type
>
>Test plan:
>1) Apply 35570
>2) Enable ILLModule sys pref through UI, or run:
>   echo "update systempreferences set value = 1 where variable = \"ILLModule\";" | koha-mysql kohadev
>3) Create a new Standard request, visit:
>   http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
>4) Input a cardnumber and/or set a library at the bottom under "Patron options".
>5) Change the type (top of the form). Notice the data from step 4) is gone.
>6) Apply patch. Repeat test plan and notice data is kept when changing request type.
>---
> Koha/ILL/Backend/intra-includes/create.inc | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/ILL/Backend/intra-includes/create.inc b/Koha/ILL/Backend/intra-includes/create.inc
>index 9f60ea6f04..99c6be2d8e 100644
>--- a/Koha/ILL/Backend/intra-includes/create.inc
>+++ b/Koha/ILL/Backend/intra-includes/create.inc
>@@ -91,14 +91,18 @@
>           Card number, username or surname:
>         </label>
>         <input type="text" name="cardnumber" id="cardnumber" autocomplete="off"
>-               type="text" value="" />
>+               type="text" value="[% whole.value.other.cardnumber | html %]" />
>       </li>
>       <li>
>         <label class="required" for="branchcode">Destination library:</label>
>         <select id="branchcode" name="branchcode">
>           <option value="" />
>           [% FOREACH branch IN branches %]
>-            <option value="[% branch.branchcode | html %]">
>+            [% IF branch.branchcode == whole.value.other.branchcode %]
>+              <option value="[% branch.branchcode | html %]" selected="selected">
>+            [% ELSE %]
>+              <option value="[% branch.branchcode | html %]">
>+            [% END %]
>               [% branch.branchname | html %]
>             </option>
>           [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35725: 160629 | 160630 | 160650 | 160661 | 160662