From 308e18cd07afc4a34d464eecf6c4b713d0f7e15d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9CByWater?= <“staff@bywatersolutions.com”> Date: Mon, 11 Mar 2013 09:12:33 -0400 Subject: [PATCH] Bug 9786 - Holds to pull showing items not available If an item is on hold and waiting for pickup, and another hold is placed on the record, a hold to pull will show in the Holds to pull report, even though there are no items that can fill that hold request. Test Plan: 1) Create a record with 1 item 2) Create 2 holds on the record 3) Fill the first hold 4) Check the Holds to pull report, it should show this record 5) Apply patch 6) Reload the Holds to pull report, it should no longer show this record --- circ/pendingreserves.pl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl index 61bace9..f8fcda5 100755 --- a/circ/pendingreserves.pl +++ b/circ/pendingreserves.pl @@ -139,7 +139,8 @@ if ( $run_report ) { reserves.found IS NULL $sqldatewhere AND (reserves.itemnumber IS NULL OR reserves.itemnumber = items.itemnumber) - AND items.itemnumber NOT IN (SELECT itemnumber FROM branchtransfers where datearrived IS NULL) + AND items.itemnumber NOT IN (SELECT itemnumber FROM branchtransfers WHERE datearrived IS NULL) + AND items.itemnumber NOT IN (SELECT itemnumber FROM reserves WHERE found IS NOT NULL) AND issues.itemnumber IS NULL AND reserves.priority <> 0 AND reserves.suspend = 0 -- 1.7.2.5