From 6a968274b8ededac87af83b74b8fca07ad7b254d Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 5 Jan 2024 12:01:55 +0100 Subject: [PATCH] Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". --- .../prog/en/includes/patron-search.inc | 45 ++++++++++++++++--- .../prog/en/modules/patroncards/edit-batch.tt | 21 +++++---- 2 files changed, 50 insertions(+), 16 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc index d1c7378863e..2c696ae9ec1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc @@ -427,7 +427,7 @@ "searchable": false, "orderable": false, "render": function( data, type, row, meta ) { - return ""; + return ""; } } [% CASE 'cardnumber' %] @@ -656,6 +656,10 @@ patron_search_form.on('submit', filter); patron_search_form.on('submit', update_search_type); + patron_search_form.on('submit', function(){ + parent_block.find(".searchheader").show(); + }); + $(".filterByLetter").on("click",function(e){ e.preventDefault(); @@ -913,14 +917,12 @@
[% IF columns.grep('checkbox').size %] -
+ + [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt index 524f5a13011..a22953937b7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt @@ -2,6 +2,7 @@ [% USE Asset %] [% PROCESS 'i18n.inc' %] [% SET footerjs = 1 %] +[% PROCESS 'patron-search.inc' %] [% INCLUDE 'doc-head-open.inc' %] [% FILTER collapse %] [% IF ( batch_id ) %] @@ -83,7 +84,7 @@ </div> </form> <div id="batch-manage" class="action"> - <a class="btn btn-default" id="additems" href="#"><i class="fa fa-plus"></i> Add patron(s)</a>[% IF ( table_loop ) %] + <a class="btn btn-default" id="additems" href="#patron_search_modal" data-toggle="modal"><i class="fa fa-plus"></i> Add patron(s)</a>[% IF ( table_loop ) %] <a class="btn btn-default" id="savedesc" href="#" data-batch_id="[% batch_id | html %]"><i class="fa fa-save"></i> Save description</a> <a class="btn btn-default" id="removeitems" href="#"><i class="fa fa-trash-can"></i> Remove selected patrons</a> <a class="btn btn-default" id="deletebatch" href="#"><i class="fa fa-minus-square"></i> Delete batch</a> @@ -199,13 +200,11 @@ function Add() { var bor_nums = document.getElementById("bor_num_list"); if (bor_nums.value == '') { - window.open("/cgi-bin/koha/members/search.pl?columns=checkbox,cardnumber,name,category,branch,dateexpiry,borrowernotes,action&selection_type=add", - 'PatronPopup', - 'width=1024,height=768,location=yes,toolbar=no,' - + 'scrollbars=yes,resize=yes'); - } else { - document.forms["add_by_bor_num"].submit(); + return true; } + + document.forms["add_by_bor_num"].submit(); + return false }; function add_user(borrowernumber) { @@ -290,8 +289,7 @@ "autoWidth": false })); $("#additems").click(function(){ - Add(); - return false; + return Add(); }); $("#removeitems").click(function(){ Remove(); @@ -376,6 +374,11 @@ }); }); </script> + + [% INCLUDE 'select2.inc' %] + [% SET columns = ['checkbox','cardnumber','name','category','branch','dateexpiry','borrowernotes','action'] %] + [% PROCESS patron_search_modal columns => columns, modal_title => t("Add patrons") %] + [% PROCESS patron_search_js columns => columns, actions => ["add"], preview_on_name_click => 1 %] [% END %] [% INCLUDE 'intranet-bottom.inc' %] -- 2.34.1